-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix image workflow #8534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image workflow #8534
Conversation
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
|
Hi @gabriel-samfira. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
estesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
This action will have to be run manually. |
Running now 🤞🏻 @gabriel-samfira 😄 |
It worked! Thanks! |
This change updates the default windows image SKU used to the
latesttag. This should always be around, and should be regularly updated to something close to the actual latest image available. For generating images, thelatesttag should be safe to use.We also disable provenance. See: docker/buildx#1509 (comment)
One important note before triggering this workflow. Github has introduced a new permissions system for
ghcr.io. Before running this workflow, someone with write access to the repo will have to navigate to https://ghcr.io/containerd/volume-copy-up and https://ghcr.io/containerd/volume-ownership and click onPackage settingson the right hand side. Once there, underActions repository access, you will need to addcontainerd/containerdas a repository, withwriteaccess.