Skip to content

Conversation

@gabriel-samfira
Copy link
Contributor

@gabriel-samfira gabriel-samfira commented May 18, 2023

This change updates the default windows image SKU used to the latest tag. This should always be around, and should be regularly updated to something close to the actual latest image available. For generating images, the latest tag should be safe to use.

We also disable provenance. See: docker/buildx#1509 (comment)

One important note before triggering this workflow. Github has introduced a new permissions system for ghcr.io. Before running this workflow, someone with write access to the repo will have to navigate to https://ghcr.io/containerd/volume-copy-up and https://ghcr.io/containerd/volume-ownership and click on Package settings on the right hand side. Once there, under Actions repository access, you will need to add containerd/containerd as a repository, with write access.

Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
@k8s-ci-robot
Copy link

Hi @gabriel-samfira. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dmcgowan dmcgowan merged commit 65c7c92 into containerd:main May 23, 2023
@gabriel-samfira
Copy link
Contributor Author

This action will have to be run manually.

@estesp
Copy link
Member

estesp commented May 23, 2023

This action will have to be run manually.

Running now 🤞🏻 @gabriel-samfira 😄

@gabriel-samfira
Copy link
Contributor Author

This action will have to be run manually.

Running now 🤞🏻 @gabriel-samfira smile

It worked! Thanks!

https://github.com/containerd/containerd/pkgs/container/volume-copy-up/95526048?tag=2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants