Skip to content

Update volume-copy-up #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
May 17, 2023
Merged

Update volume-copy-up #8524

dmcgowan merged 1 commit into from
May 17, 2023
+24 −3

Conversation

@gabriel-samfira
Copy link
Contributor

@gabriel-samfira gabriel-samfira commented May 17, 2023

Add new test cases for volumes on both Linux and Windows. These new volumes will be used to test that we don't accidentally mangle volume paths on Linux and that non-C volume mounts work properly when defined in an image on Windows.

The image version was bumped to 2.2 which allows us to build the new images and push them to the registry before we change the tests.

Related:

@k8s-ci-robot
Copy link

k8s-ci-robot commented May 17, 2023

Hi @gabriel-samfira. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabriel-samfira gabriel-samfira mentioned this pull request May 17, 2023
Merged
@gabriel-samfira
Update volume-copy-up
f8907ab 
Add new test cases for volumes on both Linux and Windows. These new
volumes will be used to test that we don't accidentally mangle volume
paths on Linux and that non-C volume mounts work properly when defined
in an image on Windows.

Signed-off-by: Gabriel Adrian Samfira <[email protected]>
@gabriel-samfira gabriel-samfira force-pushed the update-volume-copy-up branch from 2118e52 to f8907ab Compare May 17, 2023 11:20
@dmcgowan dmcgowan merged commit 44eb8f3 into containerd:main May 17, 2023
mikebrow
mikebrow reviewed May 18, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM late review :)

@gabriel-samfira
Copy link
Contributor Author

gabriel-samfira commented May 18, 2023

This job will have to be triggered manually by someone with Write access: https://github.com/containerd/containerd/actions/workflows/build-test-images.yml

Hopefully the job still works after > 1 year 😄.

@estesp
Copy link
Member

estesp commented May 18, 2023

I guess we'll find out: https://github.com/containerd/containerd/actions/runs/5014923435 :)

@estesp
Copy link
Member

estesp commented May 18, 2023

Hmm, looks like an image (MicrosoftWindowsServer:WindowsServer:2022-datacenter:20348.350.2111030009) is no longer available/deprecated?

WARNING: Querying the image of 'MicrosoftWindowsServer:WindowsServer:2022-datacenter:20348.350.2111030009' failed for an error '(ImageVersionDeprecated) VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20348.350.2111030009 is deprecated.
Code: ImageVersionDeprecated
Message: VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20348.350.2111030009 is deprecated.'. Configuring plan settings will be skipped
WARNING: Querying the image of 'MicrosoftWindowsServer:WindowsServer:2022-datacenter:20348.350.2111030009' failed for an error '(ImageVersionDeprecated) VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20348.350.2111030009 is deprecated.
Code: ImageVersionDeprecated
Message: VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20348.350.21110[30](https://github.com/containerd/containerd/actions/runs/5014923435/jobs/8989789973#step:9:31)009 is deprecated.'. Configuring plan settings will be skipped
ERROR: (ImageVersionDeprecated) VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20348.350.2111030009 is deprecated.
Code: ImageVersionDeprecated
Message: VM Image from publisher: MicrosoftWindowsServer with - Offer: WindowsServer, Sku: 2022-datacenter, Version: 20[34](https://github.com/containerd/containerd/actions/runs/5014923435/jobs/8989789973#step:9:35)8.[35](https://github.com/containerd/containerd/actions/runs/5014923435/jobs/8989789973#step:9:36)0.2111030009 is deprecated.
Error: Error: az cli script failed.
cleaning up container...
MICROSOFT_AZURE_CLI_1684419643814_CONTAINER

Error: az cli script failed.

@TBBle
Copy link
Contributor

TBBle commented May 18, 2023 •
edited
Loading

That's a version from November 2021, so not hugely surprising. Looks like MicrosoftWindowsServer:WindowsServer:2022-datacenter:20348.1726.230505 is the latest version's version-specific URN. AFAICT (not super-familiar with GitHub actions though) dropping that URN into the azure_windows_image_id input when triggering the run should work, to avoid blocking on repo changes.

@gabriel-samfira
Copy link
Contributor Author

gabriel-samfira commented May 18, 2023

Yeah. The default value is old. Let me run this action in my fork and see if anything else fails. Will ping back soon.

@gabriel-samfira
Copy link
Contributor Author

gabriel-samfira commented May 18, 2023

This PR fixes the test image workflow: #8534

Permissions on ghcr.io will most likely need to be updated. There is a note in the above mentioned PR.

@mikebrow mikebrow mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow left review comments

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabriel-samfira @k8s-ci-robot @estesp @TBBle @dmcgowan @mikebrow