Skip to content

snapshots/testsuite: Rename: fix fuse-overlayfs incompatibility#8507

Merged
fuweid merged 1 commit intocontainerd:mainfrom
AkihiroSuda:test-rename-fuse-overlayfs
May 11, 2023
Merged

snapshots/testsuite: Rename: fix fuse-overlayfs incompatibility#8507
fuweid merged 1 commit intocontainerd:mainfrom
AkihiroSuda:test-rename-fuse-overlayfs

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

For containerd/fuse-overlayfs-snapshotter#53 (comment)

CI failing

$ go test -exec rootlesskit -test.v -test.root -test.run TestFUSEOverlayFS/Rename
=== RUN   TestFUSEOverlayFS
=== RUN   TestFUSEOverlayFS/Rename
=== PAUSE TestFUSEOverlayFS/Rename
=== CONT  TestFUSEOverlayFS/Rename
    issues.go:142: Check snapshots failed: failed to create snapshot 2: failed to apply: rename /tmp/snapshot-suite-fuse-overlayfs-2521667602/work/prepare434549372/dir1 /tmp/snapshot-suite-fuse-overlayfs-2521667602/work/prepare434549372/dir2: invalid cross-device link
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602
    helpers.go:66: drwxrwxr-x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root
    helpers.go:64: -rw-------      65536 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/metadata.db [ "\x00\x00\x00\x00\x00\x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\xed\xda\f\xed\x02\x00\x00\x00\x00\x10\x00\x00\x00\x00\x00\x00\a\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\b\x00\x00\x00\x00\x00\x00\x00\f\x00\x00\x00\x00\x00\x00\x00" ...]
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1
    helpers.go:66: drwxr-xr-x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/fs
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/fs/dir1
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/fs/somefiles
    helpers.go:64: -rw-r--r--         15 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/fs/somefiles/f1 [ "was here first!" ...]
    helpers.go:64: -rw-r--r--         19 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/fs/somefiles/f2 [ "nothing interesting" ...]
    helpers.go:66: drwx--x--x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/1/work
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/3
    helpers.go:66: drwxr-xr-x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/3/fs
    helpers.go:66: drwx--x--x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/3/work
    helpers.go:66: drwx------       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/root/snapshots/3/work/work
    helpers.go:66: drwxrwxr-x       4096 /tmp/snapshot-suite-fuse-overlayfs-2521667602/work
--- FAIL: TestFUSEOverlayFS (0.01s)
    --- FAIL: TestFUSEOverlayFS/Rename (0.01s)
FAIL
[rootlesskit:child ] error: command [/tmp/go-build2417113406/b001/fuse-overlayfs-snapshotter.test -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.root -test.run=TestFUSEOverlayFS/Rename] exited: exit status 1
[rootlesskit:parent] error: child exited: exit status 1
exit status 1
FAIL    github.com/containerd/fuse-overlayfs-snapshotter        0.055s

Apparently caused by a regression in containerd v1.7.0-beta.2 containerd/containerd@d5dd11d

@AkihiroSuda AkihiroSuda added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label May 11, 2023
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit e52fbfd into containerd:main May 11, 2023
@AkihiroSuda AkihiroSuda added kind/test cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants