Skip to content

Update ttrpc to v1.2.2 #8497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estesp merged 1 commit into from
May 9, 2023
Merged

Update ttrpc to v1.2.2 #8497

estesp merged 1 commit into from
May 9, 2023

Conversation

@dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented May 9, 2023

Fix for #8390

@dmcgowan dmcgowan added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label May 9, 2023
@dmcgowan dmcgowan mentioned this pull request May 9, 2023
Merged
dcantah
dcantah approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 9, 2023

Needs rebase

@dmcgowan
Update ttrpc to v1.2.2
718250b 
Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the update-ttrpc-1.2.2 branch from 5930ff1 to 718250b Compare May 9, 2023 20:11
@dmcgowan
Copy link
Member Author

dmcgowan commented May 9, 2023

Rebased and green 😄

thaJeztah
thaJeztah approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 25ae976 into containerd:main May 9, 2023
@dmcgowan dmcgowan mentioned this pull request May 17, 2023
Merged
@dmcgowan dmcgowan deleted the update-ttrpc-1.2.2 branch April 20, 2024 00:43
@dims dims mentioned this pull request Jul 16, 2024
Merged
@thaJeztah
Copy link
Member

thaJeztah commented Jul 16, 2024 •
edited
Loading

This was cherry-picked in #8499 (1.7) and an equivalent fix (ttrpc v1.1.2) in v1.6 through #8528

@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@Iceber Iceber Iceber approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dmcgowan @AkihiroSuda @thaJeztah @estesp @Iceber @dcantah