Skip to content

update go to go1.20.4, go1.19.9#8470

Merged
mikebrow merged 1 commit intocontainerd:mainfrom
thaJeztah:update_go1.20.4
May 3, 2023
Merged

update go to go1.20.4, go1.19.9#8470
mikebrow merged 1 commit intocontainerd:mainfrom
thaJeztah:update_go1.20.4

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

go1.20.4 (released 2023-05-02) includes three security fixes to the html/template package, as well as bug fixes to the compiler, the runtime, and the crypto/subtle, crypto/tls, net/http, and syscall packages. See the Go 1.20.4 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.20.4+label%3ACherryPickApproved

release notes: https://go.dev/doc/devel/release#go1.20.4
full diff: golang/go@go1.20.3...go1.20.4

from the announcement:

These minor releases include 3 security fixes following the security policy:

  • html/template: improper sanitization of CSS values

    Angle brackets (<>) were not considered dangerous characters when inserted
    into CSS contexts. Templates containing multiple actions separated by a '/'
    character could result in unexpectedly closing the CSS context and allowing
    for injection of unexpected HMTL, if executed with untrusted input.

    Thanks to Juho Nurminen of Mattermost for reporting this issue.

    This is CVE-2023-24539 and Go issue https://go.dev/issue/59720.

  • html/template: improper handling of JavaScript whitespace

    Not all valid JavaScript whitespace characters were considered to be
    whitespace. Templates containing whitespace characters outside of the character
    set "\t\n\f\r\u0020\u2028\u2029" in JavaScript contexts that also contain
    actions may not be properly sanitized during execution.

    Thanks to Juho Nurminen of Mattermost for reporting this issue.

    This is CVE-2023-24540 and Go issue https://go.dev/issue/59721.

  • html/template: improper handling of empty HTML attributes

    Templates containing actions in unquoted HTML attributes (e.g. "attr={{.}}")
    executed with empty input could result in output that would have unexpected
    results when parsed due to HTML normalization rules. This may allow injection
    of arbitrary attributes into tags.

    Thanks to Juho Nurminen of Mattermost for reporting this issue.

    This is CVE-2023-29400 and Go issue https://go.dev/issue/59722.

go1.20.4 (released 2023-05-02) includes three security fixes to the html/template
package, as well as bug fixes to the compiler, the runtime, and the crypto/subtle,
crypto/tls, net/http, and syscall packages. See the Go 1.20.4 milestone on our
issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.20.4+label%3ACherryPickApproved

release notes: https://go.dev/doc/devel/release#go1.20.4
full diff: golang/go@go1.20.3...go1.20.4

from the announcement:

> These minor releases include 3 security fixes following the security policy:
>
> - html/template: improper sanitization of CSS values
>
>   Angle brackets (`<>`) were not considered dangerous characters when inserted
>   into CSS contexts. Templates containing multiple actions separated by a '/'
>   character could result in unexpectedly closing the CSS context and allowing
>   for injection of unexpected HMTL, if executed with untrusted input.
>
>   Thanks to Juho Nurminen of Mattermost for reporting this issue.
>
>   This is CVE-2023-24539 and Go issue https://go.dev/issue/59720.
>
> - html/template: improper handling of JavaScript whitespace
>
>   Not all valid JavaScript whitespace characters were considered to be
>   whitespace. Templates containing whitespace characters outside of the character
>   set "\t\n\f\r\u0020\u2028\u2029" in JavaScript contexts that also contain
>   actions may not be properly sanitized during execution.
>
>   Thanks to Juho Nurminen of Mattermost for reporting this issue.
>
>   This is CVE-2023-24540 and Go issue https://go.dev/issue/59721.
>
> - html/template: improper handling of empty HTML attributes
>
>   Templates containing actions in unquoted HTML attributes (e.g. "attr={{.}}")
>   executed with empty input could result in output that would have unexpected
>   results when parsed due to HTML normalization rules. This may allow injection
>   of arbitrary attributes into tags.
>
>   Thanks to Juho Nurminen of Mattermost for reporting this issue.
>
>   This is CVE-2023-29400 and Go issue https://go.dev/issue/59722.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added the cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch label May 3, 2023
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 747aafc into containerd:main May 3, 2023
@thaJeztah thaJeztah deleted the update_go1.20.4 branch May 3, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants