[release/1.6] Prepare release notes for v1.6.21 #8463

kiashok · 2023-05-01T10:09:36Z

Welcome to the v1.6.21 release of release tool!

The twenty-first patch release for containerd 1.6 contains various fixes and updates.

Notable Updates

**update runc binary to v1.1.7 (#8450)
**Remove entry for container from container store on error (#8456)
**oci: partially restore comment on read-only mounts for uid/gid uses (#8403)
**windows: Add ArgsEscaped support for CRI (#8247)
**oci: Use WithReadonlyTempMount when adding users/groups (#8357)
**update go to go1.19.9 (#8469 )
**archive: consistently respect value of WithSkipDockerManifest (#8345)

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

Contributors

Sebastiaan van Stijn
Derek McGowan
Iceber Gu
Kirtana Ashok
Justin Chadwell
Phil Estes
Akihiro Suda
Djordje Lukic
Kazuyoshi Kato
Mike Brown
Wei Fu
kiashok

Changes

25 commits

da91c3b07 Add release notes for v1.6.21
[release/1.6] update go to go1.19.9 (#8469)
- 39566aade [release/1.6] update go to go1.19.9
[release/1.6] fix the task setting the runtime path (#8454)
- e8840f688 skip TestContainerStartWithAbsRuntimePath if the runtime is v1
- 75ab094de integration: add container start test using abs runtime path
- f49254f0b WithRuntimePath uses the TaskInfo.RuntimePath field
[release/1.6 backport] update runc binary to v1.1.7 (#8450)
- ccb51ff26 update runc binary to v1.1.7
[release/1.6] Remove entry for container from container store on error (#8456)
- 95d31551d Remove entry for container from container store on error
[release/1.6 backport] oci: partially restore comment on read-only mounts for uid/gid uses (#8403)
- c33eb574d oci: partially restore comment on read-only mounts for uid/gid uses
[release/1.6 ] Add ArgsEscaped support for CRI (#8247)
- bc2e01303 Fix argsEscaped tests
- 8b81d5acc Add ArgsEscaped support for CRI
[release/1.6 backport] update runc binary to v1.1.6 (#8385)
- 57d953482 update runc binary to v1.1.6
[release/1.6 backport] oci: Use WithReadonlyTempMount when adding users/groups (#8357)
- fb5e663d0 oci: Use WithReadonlyTempMount when adding users/groups
[release/1.6] update go to go1.19.8 (#8353)
- 26efb8fd5 [release/1.6] update go to go1.19.8
[release/1.6] archive: consistently respect value of WithSkipDockerManifest (#8345)
- ec13b497e export: add test for WithSkipDockerManifest
- d1f3771c4 archive: consistently respect value of WithSkipDockerManifest

Dependency Changes

This release has no dependency changes

Previous release can be found at v1.6.20

k8s-ci-robot · 2023-05-01T10:09:45Z

Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kiashok · 2023-05-01T10:10:37Z

@dmcgowan @dcantah could you please take a look when you have some time? Thanks!

dcantah · 2023-05-01T11:20:15Z

This needs a bump to 1.6.21 https://github.com/containerd/containerd/blob/release/1.6/version/version.go#L26

releases/v1.6.21.toml

dcantah

LGTM after the two bits of feedback

dcantah · 2023-05-01T11:23:56Z

Might wanna wait for this actually #8454

kiashok · 2023-05-02T17:03:51Z

Might wanna wait for this actually #8454

This PR has been checked in. Updated this PR to include this change and contributor

estesp · 2023-05-02T18:40:38Z

Still need to add this file to the commit with the version bump:

This needs a bump to 1.6.21 https://github.com/containerd/containerd/blob/release/1.6/version/version.go#L26

kiashok · 2023-05-03T12:50:47Z

Still need to add this file to the commit with the version bump:

This needs a bump to 1.6.21 https://github.com/containerd/containerd/blob/release/1.6/version/version.go#L26

resolved this!

mikebrow

LGTM just a nit

releases/v1.6.21.toml

thaJeztah · 2023-05-03T17:51:37Z

Did we update the Go version to latest? There was a release Yesterday

thaJeztah · 2023-05-03T18:39:48Z

opened [release/1.6] update go to go1.19.9 #8469

kiashok · 2023-05-03T18:46:38Z

opened [release/1.6] update go to go1.19.9 #8469

Do we want to block this PR on go version update?

thaJeztah · 2023-05-03T18:57:18Z

I would personally consider making sure not to do a release with a go version that has CVE's attached (even though the actual CVE's wouldn't affect containerd).

There's also some fixes for compiler issues in the go1.19.9 release. We just received reports of random panics in Docker, which could be related to a bug in go1.19.8; see moby/moby#45454

estesp · 2023-05-03T19:11:44Z

I think we can probably merge the Go update in the next few hours; in that sense I don't think it is really holding up the release if we get it in today. I agree with @thaJeztah that it's easier to just make sure we are on the latest Go release that has CVE's associated with it to keep from complaints that we are using a runtime with known CVEs (even though we know containerd is unaffected)

dmcgowan · 2023-05-03T20:02:33Z

I normally avoid putting mention of go updates into the release notes unless it has a relevant since it can be a bit of a moving target. Without, easy to just release with or without it merged and not worrying about updating this every time. Its easier to get these PRs merged quicker so it doesn't need a constant update. Think just remove the mention and we'll merge and do the release when the Go update is merged.

thaJeztah · 2023-05-03T20:28:13Z

Ah, yes, that's fine with me; my comment was mostly "don't release before updating"; not specifically tied to including it in the changelog

mikebrow

LGTM

kiashok · 2023-05-04T03:59:48Z

I normally avoid putting mention of go updates into the release notes unless it has a relevant since it can be a bit of a moving target. Without, easy to just release with or without it merged and not worrying about updating this every time. Its easier to get these PRs merged quicker so it doesn't need a constant update. Think just remove the mention and we'll merge and do the release when the Go update is merged.

updated PR!

kiashok · 2023-05-04T12:58:23Z

@estesp the test failures here don't seem to be related to the changes being made here and I remember they passed earlier. Could you please help restart these tests? Thanks!

thaJeztah · 2023-05-04T17:54:57Z

One thing I forgot to mention (but should probably not be a blocker) is that go1.19.9 should resolve the issue where the soft-limit was discarded by Go, and set to the hard-limit; Revert commit that changed LimitNOFILE to infinity to avoid regressions #7566 (comment)

thaJeztah

LGTM

kiashok · 2023-05-05T00:44:02Z

do we need more sign offs for this PR to be merged? We are trying to get a new release out based on v1.6.21, so wanted to check :)

kiashok · 2023-05-05T00:45:14Z

@dcantah if you have some time would you be able to take a look please? Thanks!

dcantah

Sorry, missed the updates. LGTM

Signed-off-by: Kirtana Ashok <[email protected]>

containerd 1.6.21 Welcome to the v1.6.21 release of containerd! The twenty-first patch release for containerd 1.6 contains various fixes and updates. * **update runc binary to v1.1.7 ([containerd#8450](containerd#8450)) * **Remove entry for container from container store on error ([containerd#8456](containerd#8456)) * **oci: partially restore comment on read-only mounts for uid/gid uses ([containerd#8403](containerd#8403)) * **windows: Add ArgsEscaped support for CRI ([containerd#8247](containerd#8247)) * **oci: Use WithReadonlyTempMount when adding users/groups ([containerd#8357](containerd#8357)) * **archive: consistently respect value of WithSkipDockerManifest ([containerd#8345](containerd#8345)) See the changelog for complete list of changes Please try out the release binaries and report any issues at https://github.com/containerd/containerd/issues. * Derek McGowan * Sebastiaan van Stijn * Iceber Gu * Kirtana Ashok * Justin Chadwell * Phil Estes * Akihiro Suda * Djordje Lukic * Kazuyoshi Kato * Mike Brown * Wei Fu * kiashok <details><summary>26 commits</summary> <p> * [release/1.6] Prepare release notes for v1.6.21 ([containerd#8463](containerd#8463)) * [`9226c362a`](containerd@9226c36) Add release notes for v1.6.21 * [release/1.6] update go to go1.19.9 ([containerd#8469](containerd#8469)) * [`39566aade`](containerd@39566aa) [release/1.6] update go to go1.19.9 * [release/1.6] fix the task setting the runtime path ([containerd#8454](containerd#8454)) * [`e8840f688`](containerd@e8840f6) skip TestContainerStartWithAbsRuntimePath if the runtime is v1 * [`75ab094de`](containerd@75ab094) integration: add container start test using abs runtime path * [`f49254f0b`](containerd@f49254f) WithRuntimePath uses the TaskInfo.RuntimePath field * [release/1.6 backport] update runc binary to v1.1.7 ([containerd#8450](containerd#8450)) * [`ccb51ff26`](containerd@ccb51ff) update runc binary to v1.1.7 * [release/1.6] Remove entry for container from container store on error ([containerd#8456](containerd#8456)) * [`95d31551d`](containerd@95d3155) Remove entry for container from container store on error * [release/1.6 backport] oci: partially restore comment on read-only mounts for uid/gid uses ([containerd#8403](containerd#8403)) * [`c33eb574d`](containerd@c33eb57) oci: partially restore comment on read-only mounts for uid/gid uses * [release/1.6 ] Add ArgsEscaped support for CRI ([containerd#8247](containerd#8247)) * [`bc2e01303`](containerd@bc2e013) Fix argsEscaped tests * [`8b81d5acc`](containerd@8b81d5a) Add ArgsEscaped support for CRI * [release/1.6 backport] update runc binary to v1.1.6 ([containerd#8385](containerd#8385)) * [`57d953482`](containerd@57d9534) update runc binary to v1.1.6 * [release/1.6 backport] oci: Use WithReadonlyTempMount when adding users/groups ([containerd#8357](containerd#8357)) * [`fb5e663d0`](containerd@fb5e663) oci: Use WithReadonlyTempMount when adding users/groups * [release/1.6] update go to go1.19.8 ([containerd#8353](containerd#8353)) * [`26efb8fd5`](containerd@26efb8f) [release/1.6] update go to go1.19.8 * [release/1.6] archive: consistently respect value of WithSkipDockerManifest ([containerd#8345](containerd#8345)) * [`ec13b497e`](containerd@ec13b49) export: add test for WithSkipDockerManifest * [`d1f3771c4`](containerd@d1f3771) archive: consistently respect value of WithSkipDockerManifest </p> </details> This release has no dependency changes Previous release can be found at [v1.6.20](https://github.com/containerd/containerd/releases/tag/v1.6.20)

containerd 1.6.21 Welcome to the v1.6.21 release of containerd! The twenty-first patch release for containerd 1.6 contains various fixes and updates. * **update runc binary to v1.1.7 ([#8450](containerd/containerd#8450)) * **Remove entry for container from container store on error ([#8456](containerd/containerd#8456)) * **oci: partially restore comment on read-only mounts for uid/gid uses ([#8403](containerd/containerd#8403)) * **windows: Add ArgsEscaped support for CRI ([#8247](containerd/containerd#8247)) * **oci: Use WithReadonlyTempMount when adding users/groups ([#8357](containerd/containerd#8357)) * **archive: consistently respect value of WithSkipDockerManifest ([#8345](containerd/containerd#8345)) See the changelog for complete list of changes Please try out the release binaries and report any issues at https://github.com/containerd/containerd/issues. * Derek McGowan * Sebastiaan van Stijn * Iceber Gu * Kirtana Ashok * Justin Chadwell * Phil Estes * Akihiro Suda * Djordje Lukic * Kazuyoshi Kato * Mike Brown * Wei Fu * kiashok <details><summary>26 commits</summary> <p> * [release/1.6] Prepare release notes for v1.6.21 ([#8463](containerd/containerd#8463)) * [`9226c362a`](containerd/containerd@9226c36) Add release notes for v1.6.21 * [release/1.6] update go to go1.19.9 ([#8469](containerd/containerd#8469)) * [`39566aade`](containerd/containerd@39566aa) [release/1.6] update go to go1.19.9 * [release/1.6] fix the task setting the runtime path ([#8454](containerd/containerd#8454)) * [`e8840f688`](containerd/containerd@e8840f6) skip TestContainerStartWithAbsRuntimePath if the runtime is v1 * [`75ab094de`](containerd/containerd@75ab094) integration: add container start test using abs runtime path * [`f49254f0b`](containerd/containerd@f49254f) WithRuntimePath uses the TaskInfo.RuntimePath field * [release/1.6 backport] update runc binary to v1.1.7 ([#8450](containerd/containerd#8450)) * [`ccb51ff26`](containerd/containerd@ccb51ff) update runc binary to v1.1.7 * [release/1.6] Remove entry for container from container store on error ([#8456](containerd/containerd#8456)) * [`95d31551d`](containerd/containerd@95d3155) Remove entry for container from container store on error * [release/1.6 backport] oci: partially restore comment on read-only mounts for uid/gid uses ([#8403](containerd/containerd#8403)) * [`c33eb574d`](containerd/containerd@c33eb57) oci: partially restore comment on read-only mounts for uid/gid uses * [release/1.6 ] Add ArgsEscaped support for CRI ([#8247](containerd/containerd#8247)) * [`bc2e01303`](containerd/containerd@bc2e013) Fix argsEscaped tests * [`8b81d5acc`](containerd/containerd@8b81d5a) Add ArgsEscaped support for CRI * [release/1.6 backport] update runc binary to v1.1.6 ([#8385](containerd/containerd#8385)) * [`57d953482`](containerd/containerd@57d9534) update runc binary to v1.1.6 * [release/1.6 backport] oci: Use WithReadonlyTempMount when adding users/groups ([#8357](containerd/containerd#8357)) * [`fb5e663d0`](containerd/containerd@fb5e663) oci: Use WithReadonlyTempMount when adding users/groups * [release/1.6] update go to go1.19.8 ([#8353](containerd/containerd#8353)) * [`26efb8fd5`](containerd/containerd@26efb8f) [release/1.6] update go to go1.19.8 * [release/1.6] archive: consistently respect value of WithSkipDockerManifest ([#8345](containerd/containerd#8345)) * [`ec13b497e`](containerd/containerd@ec13b49) export: add test for WithSkipDockerManifest * [`d1f3771c4`](containerd/containerd@d1f3771) archive: consistently respect value of WithSkipDockerManifest </p> </details> This release has no dependency changes Previous release can be found at [v1.6.20](https://github.com/containerd/containerd/releases/tag/v1.6.20)

k8s-ci-robot added the needs-ok-to-test label May 1, 2023

dcantah reviewed May 1, 2023

View reviewed changes

releases/v1.6.21.toml Outdated Show resolved Hide resolved

dcantah reviewed May 1, 2023

View reviewed changes

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from 5e9dedf to 9aa41fa Compare May 1, 2023 18:32

kiashok mentioned this pull request May 2, 2023

[release/1.6] fix the task setting the runtime path #8454

Merged

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from 9aa41fa to 1599600 Compare May 2, 2023 17:02

estesp removed the needs-ok-to-test label May 2, 2023

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from 1599600 to fbb371f Compare May 3, 2023 12:49

dmcgowan approved these changes May 3, 2023

View reviewed changes

mikebrow approved these changes May 3, 2023

View reviewed changes

releases/v1.6.21.toml Outdated Show resolved Hide resolved

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from fbb371f to 66453ea Compare May 3, 2023 18:47

mikebrow approved these changes May 3, 2023

View reviewed changes

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from 66453ea to 763bb4a Compare May 4, 2023 03:58

dmcgowan approved these changes May 4, 2023

View reviewed changes

estesp approved these changes May 4, 2023

View reviewed changes

thaJeztah approved these changes May 4, 2023

View reviewed changes

dcantah approved these changes May 5, 2023

View reviewed changes

Add release notes for v1.6.21

9226c36

Signed-off-by: Kirtana Ashok <[email protected]>

kiashok force-pushed the addReleaseNotes-v.1.6.21 branch from 763bb4a to 9226c36 Compare May 5, 2023 08:51

dmcgowan approved these changes May 5, 2023

View reviewed changes

dmcgowan merged commit 3dce8eb into containerd:release/1.6 May 5, 2023

[release/1.6] Prepare release notes for v1.6.21 #8463

[release/1.6] Prepare release notes for v1.6.21 #8463

Uh oh!

Conversation

kiashok commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Updates

Contributors

Changes

Dependency Changes

Uh oh!

k8s-ci-robot commented May 1, 2023

Uh oh!

kiashok commented May 1, 2023

Uh oh!

dcantah commented May 1, 2023

Uh oh!

Uh oh!

dcantah left a comment

Choose a reason for hiding this comment

Uh oh!

dcantah commented May 1, 2023

Uh oh!

kiashok commented May 2, 2023

Uh oh!

estesp commented May 2, 2023

Uh oh!

kiashok commented May 3, 2023

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thaJeztah commented May 3, 2023

Uh oh!

thaJeztah commented May 3, 2023

Uh oh!

kiashok commented May 3, 2023

Uh oh!

thaJeztah commented May 3, 2023

Uh oh!

estesp commented May 3, 2023

Uh oh!

dmcgowan commented May 3, 2023

Uh oh!

thaJeztah commented May 3, 2023

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

kiashok commented May 4, 2023

Uh oh!

kiashok commented May 4, 2023

Uh oh!

thaJeztah commented May 4, 2023

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

kiashok commented May 5, 2023

Uh oh!

kiashok commented May 5, 2023

Uh oh!

dcantah left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kiashok commented May 1, 2023 •

edited

Loading