Skip to content

[release/1.7] Remove entry for container from container store on error #8457

Merged
AkihiroSuda merged 1 commit intocontainerd:release/1.7from
kiashok:port_deleteCtr_1.7
Apr 30, 2023
Merged

[release/1.7] Remove entry for container from container store on error #8457
AkihiroSuda merged 1 commit intocontainerd:release/1.7from
kiashok:port_deleteCtr_1.7

Conversation

@kiashok
Copy link
Copy Markdown
Contributor

@kiashok kiashok commented Apr 27, 2023 •
edited by fuweid
Loading

Cherry pick commit d9f3e38

Cherry-pick #8414

Remove entry for container from container store on error
6b3ae01 
If containerd does not see a container but criservice's
container store does, then we should try to recover from
this error state by removing the container from criservice's
container store as well.

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit d9f3e38)
Signed-off-by: Kirtana Ashok <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 27, 2023

Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kiashok
Copy link
Copy Markdown
Contributor Author

kiashok commented Apr 28, 2023

@estesp there seems to be an unrelated failure on this PR as well. Could you please help restart it?

@AkihiroSuda AkihiroSuda merged commit 087bb32 into containerd:release/1.7 Apr 30, 2023
@kiashok kiashok mentioned this pull request May 5, 2023
Closed
@dmcgowan dmcgowan mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiashok @k8s-ci-robot @dmcgowan @AkihiroSuda