Move logrus setup code to log package #8441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <[email protected]>
dmcgowan
approved these changes
Apr 24, 2023
samuelkarp
approved these changes
Apr 24, 2023
Iceber
reviewed
May 6, 2023
| ) | ||
|
|
||
| // SetLevel sets log level globally. | ||
| func SetLevel(level string) error { |
Member
There was a problem hiding this comment.
Is it better if the type of the parameter is Level? so that when using it, we can call log.SetLevel(log.InfoLevel)
Of course, we can also add a check for the level parameter, eg.
// SetLevel sets log level globally.
func SetLevel(level Level) error {
lvl, err := logrus.ParseLevel(level.String())
if err != nil {
return err
}
logrus.SetLevel(lvl)
return nil
}
This was referenced Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the spread of logrus imports. It moves
logrussetup code to thelogpackage to simplify migration to a new logger in the future (containerd/log#2)