Hi @sxllwx. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

What else do I need to do to promote this PR?

/ok-to-test

@dims: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

I don't think the failing tests are related to this change
/retest

@brianpursley: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

@dcantah Can we get /ok-to-test on this PR?

There is another kubernetes PR that depends on this PR being merged to fix an issue with port forwarding, so I'm hoping this change can get in.

Do you have any other thoughts on this PR? What else might be needed to move this forward?

/ok-to-test

/retest

Any plans to continue/merge this? @sxllwx @brianpursley

Any plans to continue/merge this? @sxllwx @brianpursley

Yes. I hope so, but I'm not sure how to focus attention on this PR.

I've tried to push the PR to be merged via slack and github, but haven't gotten a response yet.😥

What else do I need to do to promote this PR? @dcantah

@sxllwx Nothing more on your end, I apologize for this falling off my radar 🫠. We'll need one other maintainer to approve and we're good to check in. Thanks for your patience

@sxllwx Could you rebase on main and push again so we can get a clearer CI signal?

@sxllwx Could you rebase on main and push again so we can get a clearer CI signal?

Thanks for your support, I've rebase on main and push again. PTAL thx~

This fix should be cherry-picked into release/1.6 and release/1.7

This fix should be cherry-picked into release/1.6 and release/1.7

Thanks for your help, I have submitted PRs to do cherry-pick, please take a look. thx

Thanks, @estesp

Regarding the 1.6 and 1.7 backports, what is the process for getting this into the next patch releases?

I see here, that it says it needs to be added to a milestone

@brianpursley Nothing needs to be done at this point, the next time we go to make a release it will be included. We don't have a set release schedule, just whenever we feel there's decent payload or when there's a security fix. I think this probably justifies a release though so I'll look at getting the notes drafted

@sxllwx @brianpursley is this PR sufficient to solve the SSL port forwarding issue (kubernetes/kubernetes#111825) or is kubernetes/kubernetes#117493 needed as well?

Latest containerd version supported for 1.27 on EKS is 1.6.19 which would mean a mere 3 patch versions stand between EKS users and the ability to use SSL in Postgres again -if this does indeed solve the issue.

@apjoseph

Sorry for the late reply.

This PR is enough to fix kubernetes/kubernetes#74551

We have observed that many non-containerd CRIs use code related to https://github.com/kubernetes/kubernetes/pull/117493/files in kubelet, so we hope to return these bugfixes to kubelet.

If you still encounter problems later, please let me know (of course, you can also let me know if the problem has been solved.). You can leave a message at kubernetes/kubernetes#74551. grateful.