Skip to content

ctr: Add sandbox flag to ctr run#8413

Merged
fuweid merged 1 commit intocontainerd:mainfrom
dcantah:sb_ctr_run
Apr 20, 2023
Merged

ctr: Add sandbox flag to ctr run#8413
fuweid merged 1 commit intocontainerd:mainfrom
dcantah:sb_ctr_run

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Apr 18, 2023

Add a flag to be able to run a container in a given sandbox.

@dcantah dcantah marked this pull request as draft April 18, 2023 19:24
@dcantah dcantah marked this pull request as ready for review April 20, 2023 00:23
@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Apr 20, 2023

/retest

Comment thread cmd/ctr/commands/containers/containers.go Outdated
Comment thread cmd/ctr/commands/run/run.go Outdated
Comment thread cmd/ctr/commands/run/run.go Outdated
Add a flag to be able to run a container in a given sandbox.

Signed-off-by: Danny Canter <[email protected]>
@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Apr 20, 2023

@Iceber Done, thanks!

Copy link
Copy Markdown
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit fdd1be6 into containerd:main Apr 20, 2023
@dmcgowan dmcgowan added the cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch label May 10, 2023
@samuelkarp
Copy link
Copy Markdown
Member

/cherrypick release/1.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@samuelkarp: new pull request created: #9449

Details

In response to this:

/cherrypick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp samuelkarp added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch kind/enhancement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants