Add support for proxy differ #8399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Member
|
cc @wllenyj |
dcantah
reviewed
Apr 18, 2023
|
|
||
| // NewDiffApplier returns a new comparer and applier which communicates | ||
| // over a GRPC connection. | ||
| func NewDiffApplier(client diffapi.DiffClient) interface{} { |
Member
There was a problem hiding this comment.
Boring go nit: Given we list 1.19 in our go.mod, should we use any for all interface{} uses from now on?
dcantah
approved these changes
Apr 18, 2023
Member
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Seems to work locally with a dummy test, LGTM
dmcgowan
added
the
cherry-pick/1.7.x
This was referenced Jun 2, 2023
dmcgowan
added
cherry-picked/1.7.x
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the "diff" type proxy plugin. This allows for out of process diff plugins to be used using the existing proxy plugin framework. The
contribaddition makes it easier to implement such plugins, similar to thesnapshotserviceincontrib.Moves the client proxy out of the client package to a package under
diff, similar to our other client proxies.A simple example is at https://gist.github.com/dmcgowan/93a19e4183493b46c5bf8cc3d5be9e59
Since we already have support for multiple differs (similar to how we have support for multiple snapshotters), configuring is easy. Just add the proxy plugin and update the diff service to use it (add it before walking to try the proxy first).