Skip to content

Conversation

@thaJeztah
Copy link
Member

release notes: https://github.com/opencontainers/runc/releases/tag/v1.1.6
full diff: opencontainers/runc@v1.1.5...v1.1.6

This is the sixth patch release in the 1.1.z series of runc, which fixes a series of cgroup-related issues.

Note that this release can no longer be built from sources using Go 1.16. Using a latest maintained Go 1.20.x or Go 1.19.x release is recommended. Go 1.17 can still be used.

  • systemd cgroup v1 and v2 drivers were deliberately ignoring UnitExist error from systemd while trying to create a systemd unit, which in some scenarios may result in a container not being added to the proper systemd unit and cgroup.
  • systemd cgroup v2 driver was incorrectly translating cpuset range from spec's resources.cpu.cpus to systemd unit property (AllowedCPUs) in case of more than 8 CPUs, resulting in the wrong AllowedCPUs setting.
  • systemd cgroup v1 driver was prefixing container's cgroup path with the path of PID 1 cgroup, resulting in inability to place PID 1 in a non-root cgroup.
  • runc run/start may return "permission denied" error when starting a rootless container when the file to be executed does not have executable bit set for the user, not taking the CAP_DAC_OVERRIDE capability into account. This is a regression in runc 1.1.4, as well as in Go 1.20 and 1.20.1
  • cgroup v1 drivers are now aware of misc controller.

(cherry picked from commit 49111b1)

release notes: https://github.com/opencontainers/runc/releases/tag/v1.1.6
full diff: opencontainers/runc@v1.1.5...v1.1.6

This is the sixth patch release in the 1.1.z series of runc, which fixes
a series of cgroup-related issues.

Note that this release can no longer be built from sources using Go
1.16. Using a latest maintained Go 1.20.x or Go 1.19.x release is
recommended. Go 1.17 can still be used.

- systemd cgroup v1 and v2 drivers were deliberately ignoring UnitExist error
  from systemd while trying to create a systemd unit, which in some scenarios
  may result in a container not being added to the proper systemd unit and
  cgroup.
- systemd cgroup v2 driver was incorrectly translating cpuset range from spec's
  resources.cpu.cpus to systemd unit property (AllowedCPUs) in case of more
  than 8 CPUs, resulting in the wrong AllowedCPUs setting.
- systemd cgroup v1 driver was prefixing container's cgroup path with the path
  of PID 1 cgroup, resulting in inability to place PID 1 in a non-root cgroup.
- runc run/start may return "permission denied" error when starting a rootless
  container when the file to be executed does not have executable bit set for
  the user, not taking the CAP_DAC_OVERRIDE capability into account. This is
  a regression in runc 1.1.4, as well as in Go 1.20 and 1.20.1
- cgroup v1 drivers are now aware of misc controller.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 49111b1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 13, 2023

edit: looks like we should be good to go; #8384 (comment)

@thaJeztah thaJeztah closed this Apr 15, 2023
@thaJeztah thaJeztah reopened this Apr 15, 2023
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit ee0637a into containerd:release/1.6 Apr 18, 2023
@thaJeztah thaJeztah deleted the 1.6_backport_runc_binary_1.1.6 branch April 18, 2023 11:27
aravindhp added a commit to openshift/containerd that referenced this pull request May 24, 2023
containerd 1.6.21

Welcome to the v1.6.21 release of containerd!

The twenty-first patch release for containerd 1.6 contains various fixes and updates.

* **update runc binary to v1.1.7 ([containerd#8450](containerd#8450))
* **Remove entry for container from container store on error ([containerd#8456](containerd#8456))
* **oci: partially restore comment on read-only mounts for uid/gid uses ([containerd#8403](containerd#8403))
* **windows: Add ArgsEscaped support for CRI ([containerd#8247](containerd#8247))
* **oci: Use WithReadonlyTempMount when adding users/groups ([containerd#8357](containerd#8357))
* **archive: consistently respect value of WithSkipDockerManifest ([containerd#8345](containerd#8345))

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

* Derek McGowan
* Sebastiaan van Stijn
* Iceber Gu
* Kirtana Ashok
* Justin Chadwell
* Phil Estes
* Akihiro Suda
* Djordje Lukic
* Kazuyoshi Kato
* Mike Brown
* Wei Fu
* kiashok

<details><summary>26 commits</summary>
<p>

* [release/1.6] Prepare release notes for v1.6.21  ([containerd#8463](containerd#8463))
  * [`9226c362a`](containerd@9226c36) Add release notes for v1.6.21
* [release/1.6] update go to go1.19.9 ([containerd#8469](containerd#8469))
  * [`39566aade`](containerd@39566aa) [release/1.6] update go to go1.19.9
* [release/1.6] fix the task setting the runtime path ([containerd#8454](containerd#8454))
  * [`e8840f688`](containerd@e8840f6) skip TestContainerStartWithAbsRuntimePath if the runtime is v1
  * [`75ab094de`](containerd@75ab094) integration: add container start test using abs runtime path
  * [`f49254f0b`](containerd@f49254f) WithRuntimePath uses the TaskInfo.RuntimePath field
* [release/1.6 backport] update runc binary to v1.1.7 ([containerd#8450](containerd#8450))
  * [`ccb51ff26`](containerd@ccb51ff) update runc binary to v1.1.7
* [release/1.6] Remove entry for container from container store on error ([containerd#8456](containerd#8456))
  * [`95d31551d`](containerd@95d3155) Remove entry for container from container store on error
* [release/1.6 backport] oci: partially restore comment on read-only mounts for uid/gid uses ([containerd#8403](containerd#8403))
  * [`c33eb574d`](containerd@c33eb57) oci: partially restore comment on read-only mounts for uid/gid uses
* [release/1.6 ] Add ArgsEscaped support for CRI ([containerd#8247](containerd#8247))
  * [`bc2e01303`](containerd@bc2e013) Fix argsEscaped tests
  * [`8b81d5acc`](containerd@8b81d5a) Add ArgsEscaped support for CRI
* [release/1.6 backport] update runc binary to v1.1.6 ([containerd#8385](containerd#8385))
  * [`57d953482`](containerd@57d9534) update runc binary to v1.1.6
* [release/1.6 backport] oci: Use WithReadonlyTempMount when adding users/groups ([containerd#8357](containerd#8357))
  * [`fb5e663d0`](containerd@fb5e663) oci: Use WithReadonlyTempMount when adding users/groups
* [release/1.6] update go to go1.19.8 ([containerd#8353](containerd#8353))
  * [`26efb8fd5`](containerd@26efb8f) [release/1.6] update go to go1.19.8
* [release/1.6] archive: consistently respect value of WithSkipDockerManifest ([containerd#8345](containerd#8345))
  * [`ec13b497e`](containerd@ec13b49) export: add test for WithSkipDockerManifest
  * [`d1f3771c4`](containerd@d1f3771) archive: consistently respect value of WithSkipDockerManifest
</p>
</details>

This release has no dependency changes

Previous release can be found at [v1.6.20](https://github.com/containerd/containerd/releases/tag/v1.6.20)
Mengkzhaoyun pushed a commit to open-beagle/containerd that referenced this pull request Jun 9, 2023
containerd 1.6.21

Welcome to the v1.6.21 release of containerd!

The twenty-first patch release for containerd 1.6 contains various fixes and updates.

* **update runc binary to v1.1.7 ([#8450](containerd/containerd#8450))
* **Remove entry for container from container store on error ([#8456](containerd/containerd#8456))
* **oci: partially restore comment on read-only mounts for uid/gid uses ([#8403](containerd/containerd#8403))
* **windows: Add ArgsEscaped support for CRI ([#8247](containerd/containerd#8247))
* **oci: Use WithReadonlyTempMount when adding users/groups ([#8357](containerd/containerd#8357))
* **archive: consistently respect value of WithSkipDockerManifest ([#8345](containerd/containerd#8345))

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

* Derek McGowan
* Sebastiaan van Stijn
* Iceber Gu
* Kirtana Ashok
* Justin Chadwell
* Phil Estes
* Akihiro Suda
* Djordje Lukic
* Kazuyoshi Kato
* Mike Brown
* Wei Fu
* kiashok
<details><summary>26 commits</summary>
<p>

* [release/1.6] Prepare release notes for v1.6.21  ([#8463](containerd/containerd#8463))
  * [`9226c362a`](containerd/containerd@9226c36) Add release notes for v1.6.21
* [release/1.6] update go to go1.19.9 ([#8469](containerd/containerd#8469))
  * [`39566aade`](containerd/containerd@39566aa) [release/1.6] update go to go1.19.9
* [release/1.6] fix the task setting the runtime path ([#8454](containerd/containerd#8454))
  * [`e8840f688`](containerd/containerd@e8840f6) skip TestContainerStartWithAbsRuntimePath if the runtime is v1
  * [`75ab094de`](containerd/containerd@75ab094) integration: add container start test using abs runtime path
  * [`f49254f0b`](containerd/containerd@f49254f) WithRuntimePath uses the TaskInfo.RuntimePath field
* [release/1.6 backport] update runc binary to v1.1.7 ([#8450](containerd/containerd#8450))
  * [`ccb51ff26`](containerd/containerd@ccb51ff) update runc binary to v1.1.7
* [release/1.6] Remove entry for container from container store on error ([#8456](containerd/containerd#8456))
  * [`95d31551d`](containerd/containerd@95d3155) Remove entry for container from container store on error
* [release/1.6 backport] oci: partially restore comment on read-only mounts for uid/gid uses ([#8403](containerd/containerd#8403))
  * [`c33eb574d`](containerd/containerd@c33eb57) oci: partially restore comment on read-only mounts for uid/gid uses
* [release/1.6 ] Add ArgsEscaped support for CRI ([#8247](containerd/containerd#8247))
  * [`bc2e01303`](containerd/containerd@bc2e013) Fix argsEscaped tests
  * [`8b81d5acc`](containerd/containerd@8b81d5a) Add ArgsEscaped support for CRI
* [release/1.6 backport] update runc binary to v1.1.6 ([#8385](containerd/containerd#8385))
  * [`57d953482`](containerd/containerd@57d9534) update runc binary to v1.1.6
* [release/1.6 backport] oci: Use WithReadonlyTempMount when adding users/groups ([#8357](containerd/containerd#8357))
  * [`fb5e663d0`](containerd/containerd@fb5e663) oci: Use WithReadonlyTempMount when adding users/groups
* [release/1.6] update go to go1.19.8 ([#8353](containerd/containerd#8353))
  * [`26efb8fd5`](containerd/containerd@26efb8f) [release/1.6] update go to go1.19.8
* [release/1.6] archive: consistently respect value of WithSkipDockerManifest ([#8345](containerd/containerd#8345))
  * [`ec13b497e`](containerd/containerd@ec13b49) export: add test for WithSkipDockerManifest
  * [`d1f3771c4`](containerd/containerd@d1f3771) archive: consistently respect value of WithSkipDockerManifest
</p>
</details>

This release has no dependency changes

Previous release can be found at [v1.6.20](https://github.com/containerd/containerd/releases/tag/v1.6.20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants