Skip to content

[release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Apr 6, 2023
Merged

[release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups #8358

dmcgowan merged 1 commit into from
Apr 6, 2023

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 5, 2023

(cherry picked from commit cab0562)

The #8259 change added a new WithReadonlyTempMount that will force the mount to be readonly.

This change removes the tryReadonlyMounts and uses that function.

Relates to #8259 Related: rumpl/moby#92 and moby/moby#45267

Note: once this PR is good to go I will backport these to 1.6 and 1.7, this is needed for moby's migration to the containerd image store and moby uses 1.6.x

@rumpl @thaJeztah
oci: Use WithReadonlyTempMount when adding users/groups
54d12b8 
Signed-off-by: Djordje Lukic <[email protected]>
(cherry picked from commit cab0562)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title [release/1.7] oci: Use WithReadonlyTempMount when adding users/groups [release/1.7 backport] oci: Use WithReadonlyTempMount when adding users/groups Apr 5, 2023
@thaJeztah thaJeztah mentioned this pull request Apr 5, 2023
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 5, 2023

/retest

@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 6, 2023

whoop, all green now 🎉

@dmcgowan dmcgowan merged commit d945322 into containerd:release/1.7 Apr 6, 2023
@thaJeztah thaJeztah deleted the 1.7_backport_oci_readonly_mounts branch April 6, 2023 17:59
@kiashok kiashok mentioned this pull request May 5, 2023
Closed
@dmcgowan dmcgowan mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @dmcgowan @estesp @rumpl