oci: Use WithReadonlyTempMount when adding users/groups #8351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Djordje Lukic <[email protected]>
thaJeztah
added
cherry-pick/1.6.x
cherry-pick/1.7.x
Member
|
I added cherry-pick labels for this, as it reduces the risk of code diverging |
Member
|
derp; new code isn't doing the same, but actually fixing the overlay mounts (updated my previous comment) |
estesp
approved these changes
Apr 5, 2023
dmcgowan
approved these changes
Apr 5, 2023
This was referenced Apr 5, 2023
thaJeztah
added
cherry-picked/1.6.x
fuweid
reviewed
Apr 7, 2023
| // tryReadonlyMounts is used by the options which are trying to get user/group | ||
| // information from container's rootfs. Since the option does read operation | ||
| // only, this helper will append ReadOnly mount option to prevent linux kernel | ||
| // from syncing whole filesystem in umount syscall. |
Member
There was a problem hiding this comment.
I think we should keep the comments here to know why we use readonly mount .... no just remove it
Member
There was a problem hiding this comment.
This was referenced Apr 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #8259 change added a new
WithReadonlyTempMountthat will force the mount to be readonly.This change removes the
tryReadonlyMountsand uses that function.Relates to #8259
Related: rumpl/moby#92 and moby/moby#45267
Note: once this PR is good to go I will backport these to 1.6 and 1.7, this is needed for moby's migration to the containerd image store and moby uses 1.6.x