remotes/docker: Add Mounted and Exists push status#8330
remotes/docker: Add Mounted and Exists push status#8330estesp merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @vvoland. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Windows test failure seems unrelated. |
| resp.Body.Close() | ||
| resp = nil | ||
| case http.StatusCreated: | ||
| mounted = true |
There was a problem hiding this comment.
Along the same lines as moby/moby#44963 (comment) (https://github.com/moby/moby/blob/0656059ae7ab1d0b14afd3bd5f4533f2f2083ff0/distribution/push_v2.go#L379), would it make sense for this to also include where it mounted from? (perhaps a string or ref pointer instead of just a bool? I am not a containerd maintainer though 🙇)
There was a problem hiding this comment.
Ah, yeah, good point. Will do it on Monday next week.
This makes it possible to check whether content didn't actually need to be pushed to the remote registry and was cross-repo mounted or already existed. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
remotes-docker-status-exists-mounted
branch
from
64191a0 to
dfc7590
Compare
|
/cc @dmcgowan |
|
@thaJeztah @AkihiroSuda PTAL |
|
Rebased and pushed changes suggested some time ago by @thaJeztah on Slack. |
|
/ok-to-test |
chrishenzie
added
cherry-picked/1.6.x
7 participants
This makes it possible to check whether content didn't actually need to be pushed to the remote registry and was cross-repo mounted or already existed.