ctr/tasks: fix unmarshal the task metrics for cgroup v1#8302
Merged
fuweid merged 1 commit intocontainerd:mainfrom Mar 24, 2023
Merged
ctr/tasks: fix unmarshal the task metrics for cgroup v1#8302fuweid merged 1 commit intocontainerd:mainfrom
fuweid merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @Iceber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Iceber
force-pushed
the
fix_ctr_task_metrics
branch
3 times, most recently
from
a2fb8a2 to
e29f76a
Compare
Signed-off-by: Iceber Gu <[email protected]>
Iceber
force-pushed
the
fix_ctr_task_metrics
branch
from
e29f76a to
1be08b1
Compare
AkihiroSuda
approved these changes
Mar 24, 2023
fuweid
added
the
cherry-pick/1.7.x
fuweid
added
cherry-picked/1.7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8301 with a relatively minor change, since there is no way to predict when hcsshim's cgroup dependencie will be upgraded to v3.Ensure thatctr task metricsare available on a system with cgroupv1 before hcshim's cgroup is upgraded to v3.fix: #8301
Match the type by the type url of the metric data.
This approach seems more reasonable and stable than the previous temporary solution(https://github.com/containerd/containerd/issues/8301#issuecomment-1480556963)，and does not care about hcsshim's dependencies
related pr: #8234