Skip to content

[WIP] feat: Implement image verification proxy plugin type #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethan-lowman-dd wants to merge 1 commit into from
Closed

[WIP] feat: Implement image verification proxy plugin type #8269

ethan-lowman-dd wants to merge 1 commit into from

Conversation

@ethan-lowman-dd
Copy link
Contributor

@ethan-lowman-dd ethan-lowman-dd commented Mar 14, 2023

This PR implements a plugin system for verifying image pulls (#6691).

This supersedes #6994 to implement the plugin using a gRPC proxy plugin called from the Transfer Service rather than a ttrpc plugin to the CRI.

See https://github.com/DataDog/containerd/blob/img-verifier-proxy-plugin/verifier/example/README.md to test an example plugin.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Mar 14, 2023

Hi @ethan-lowman-dd. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ethan-lowman-dd ethan-lowman-dd mentioned this pull request Mar 15, 2023
Merged
@ethan-lowman-dd
Copy link
Contributor Author

ethan-lowman-dd commented May 5, 2023

From March 23 community meeting: should use binary shim model instead of proxy plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethan-lowman-dd @k8s-ci-robot