Sandbox: Fix/enhance error messages for Create#8203
Merged
fuweid merged 1 commit intocontainerd:mainfrom Mar 4, 2023
Merged
Conversation
CreateSandbox states "failed to start sandbox". This is quite confusing when you're perusing logs and trying to pinpoint how far a shim got in its execution. Signed-off-by: Danny Canter <[email protected]>
samuelkarp
approved these changes
Mar 4, 2023
fuweid
approved these changes
Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateSandbox states "failed to start sandbox". This is quite confusing when you're perusing logs and trying to pinpoint how far a shim got in its execution.
Example of what you'd get from k8s:
error="failed to create sandbox \"35ec3d335ff8baf64d89c09f79279280741b1f8822dfdc8aaf338f20e437a571\": failed to start sandbox 35ec3d335ff8baf64d89c09f79279280741b1f8822dfdc8aaf338f20e437a571