Treat sandboxes as root gc resources and scan referenced objects #8172
Conversation
Signed-off-by: Henry Wang <[email protected]>
|
Hi @henry118. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It makes sense for the sandbox to own the networking. What is the case where sandboxes existing without containers though since we already have containers as roots. |
|
This makes sense since the sandboxes aren't part of GC today and the resources they manage are already managed as roots. They likely have the same issues with auto deletion that containers would, that they may have other resources (such as shim processes) which aren't managed through the metadata service. |
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
4 participants
Treat sandboxes as root GC resources and scan referenced objects.
This makes sandbox objects the owner of other resources like networking