sandbox: create sandbox with network namespace path#8149
Merged
mxpv merged 1 commit intocontainerd:mainfrom Mar 8, 2023
Merged
sandbox: create sandbox with network namespace path#8149mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
dcantah
approved these changes
Feb 22, 2023
samuelkarp
reviewed
Feb 26, 2023
Burning1020
force-pushed
the
sb-netns
branch
3 times, most recently
from
79c4730 to
3fb3c11
Compare
Member
Author
|
@samuelkarp PTAL |
samuelkarp
approved these changes
Mar 1, 2023
fuweid
reviewed
Mar 1, 2023
Burning1020
force-pushed
the
sb-netns
branch
2 times, most recently
from
7be98f7 to
36b7c27
Compare
fuweid
reviewed
Mar 6, 2023
Burning1020
force-pushed
the
sb-netns
branch
4 times, most recently
from
c78e453 to
9d2eceb
Compare
Member
|
I'm in favor of switching back to the version with the proto update. There was already approval from those API owners to make that change before the final 1.7 release. |
Signed-off-by: Zhang Tianyang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #8129