Add Fields type alias to log package #8143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <[email protected]>
dcantah
approved these changes
Feb 21, 2023
fuweid
approved these changes
Feb 21, 2023
dcantah
added a commit
to dcantah/containerd
that referenced
this pull request
Feb 21, 2023
containerd#8143 added an alias for logrus.Fields and moved over most usages to this alias, but there was one straggler. Signed-off-by: Danny Canter <[email protected]>
jsturtevant
pushed a commit
to jsturtevant/containerd
that referenced
this pull request
Sep 21, 2023
containerd#8143 added an alias for logrus.Fields and moved over most usages to this alias, but there was one straggler. Signed-off-by: Danny Canter <[email protected]>
juliusl
pushed a commit
to juliusl/containerd
that referenced
this pull request
Jan 26, 2024
containerd#8143 added an alias for logrus.Fields and moved over most usages to this alias, but there was one straggler. Signed-off-by: Danny Canter <[email protected]>
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging with custom fields, like:
you're forced to do two imports
This PR adds a type alias to log package, so we end up with just one import:
Which often reduces the number of imports and makes log package a bit nicer.