sandbox: start sandbox with options#8129
Merged
kzys merged 1 commit intocontainerd:mainfrom Feb 21, 2023
Merged
Conversation
Signed-off-by: Zhang Tianyang <[email protected]>
Member
Author
|
/retest |
Member
Author
|
BTW, NetNSPath should also be passed into CreateSandboxRequest while there is no resonable field could hold it. Should I add a String member so that it can take netns information? |
fuweid
approved these changes
Feb 19, 2023
mxpv
approved these changes
Feb 20, 2023
Member
This is fine I think. |
kzys
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options should be passed into create request