runtime/v2: Call onCloseWithShimLog for grpc shims #8120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
commented
Feb 16, 2023
mxpv
reviewed
Feb 16, 2023
dcantah
force-pushed
the
grpc-shim-callbackfn
branch
from
a3b0e27 to
3cf03a2
Compare
Member
Author
|
@mxpv Addressed feedback, thanks! |
fuweid
reviewed
Feb 16, 2023
dcantah
force-pushed
the
grpc-shim-callbackfn
branch
2 times, most recently
from
7464866 to
9224f88
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
Member
|
/retest |
Member
|
/retest |
mxpv
reviewed
Feb 20, 2023
mxpv
approved these changes
Feb 20, 2023
Member
|
/retest |
dcantah
force-pushed
the
grpc-shim-callbackfn
branch
from
9224f88 to
c15b75c
Compare
fuweid
approved these changes
Feb 21, 2023
We pass in a callback using the ttrpc.WithOnClose functionality for shims that use ttrpc, but with the newly added ability to use GRPC for shims this was left as a follow-up. It doesn't seem like grpc-go has anything similar so some options (that I could see) are: This change introduces a new grpcConn wrapper type for the connection that exposes a method to get notified when the users callback has run, the same in functionality as TTRPC's `UserOnCloseWait`. The callback gets passed in in a new `grpcDialContext` function that will: 1. Dial the connection as normal 2. Spin off a goroutine that will monitor the connections state until it transitions to idle or shutdown and will then run the callback. Signed-off-by: Danny Canter <[email protected]>
dcantah
force-pushed
the
grpc-shim-callbackfn
branch
from
c15b75c to
4278fbb
Compare
containerd#8143 added an alias for logrus.Fields and moved over most usages to this alias, but there was one straggler. Signed-off-by: Danny Canter <[email protected]>
Member
Author
|
@mxpv There was one last |
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass in a callback using the ttrpc.WithOnClose functionality
for shims that use ttrpc, but with the newly added ability to use
GRPC for shims this was left as a follow-up.
This change introduces a new grpcConn wrapper type for the connection
that exposes a method to get notified when the users callback has run,
the same in functionality as TTRPC's
UserOnCloseWait. The callbackgets passed in in a new
grpcDialContextfunction that will:until it transitions to idle or shutdown and will then run the
callback.