Add macOS build note#8115
Conversation
|
Hi @bennett-white. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Discussed change with @mikebrow |
bennett-white
force-pushed
the
Add-macos-note
branch
3 times, most recently
from
f11c5cd to
008d734
Compare
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please see comments above
bennett-white
force-pushed
the
Add-macos-note
branch
from
2a316da to
b3eadf7
Compare
|
I have updated the Pull Request with the requested changes and resolved it to a single commit. |
bennett-white
force-pushed
the
Add-macos-note
branch
from
b3eadf7 to
30a04d7
Compare
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM just need to address the project test rejection
bennett-white
force-pushed
the
Add-macos-note
branch
3 times, most recently
from
34bc412 to
30baa82
Compare
|
Looks good but has a whitespace issue; run this locally and it should report where: |
bennett-white
force-pushed
the
Add-macos-note
branch
from
30baa82 to
20f06d5
Compare
Co-authored-by: AkihiroSuda <[email protected]> Co-authored-by: Mike Brown <[email protected]> Signed-off-by: Bennett White <[email protected]>
bennett-white
force-pushed
the
Add-macos-note
branch
from
20f06d5 to
dc27cc0
Compare
8 participants
There is currently no mention of OS requirement in BUILDING.md under the Building containerd from source section. It is mentioned that containerd is available for Linux and Windows in README.md, but I find it worth noting that a flawed build is possible on macOS.