[sandbox] Use options to pass PodSandboxConfig to shims#8100
Merged
kzys merged 1 commit intocontainerd:mainfrom Feb 13, 2023
Merged
[sandbox] Use options to pass PodSandboxConfig to shims#8100kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
mxpv
added
area/cri
mxpv
changed the title
samuelkarp
approved these changes
Feb 13, 2023
cpuguy83
approved these changes
Feb 13, 2023
kzys
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow sandboxed shims access
PodSandboxConfigwhen creating a sandbox, this way shims can configure many things - DNS, ports, etc./cc @dcantah this might be useful for your use case too.
Signed-off-by: Maksym Pavlenko [email protected]