Skip to content

loadConfig pre-inspection in advance#8097

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
helen-frank:feature/configloadPre-inspectionInAdvance
Feb 13, 2023
Merged

loadConfig pre-inspection in advance#8097
dmcgowan merged 1 commit intocontainerd:mainfrom
helen-frank:feature/configloadPre-inspectionInAdvance

Conversation

@helen-frank
Copy link
Copy Markdown

@helen-frank helen-frank commented Feb 13, 2023

loadConfig pre-inspection in advance

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 13, 2023

Hi @helen-frank. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helen-frank helen-frank force-pushed the feature/configloadPre-inspectionInAdvance branch from e3e5c12 to c00eece Compare February 13, 2023 10:48
@helen-frank helen-frank force-pushed the feature/configloadPre-inspectionInAdvance branch from c00eece to a8bb1ad Compare February 13, 2023 12:11
estesp
estesp approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; seems reasonable for the early exit when gRPC address is unset. The other clause doesn't have any value in moving, but no downside either.

@dmcgowan dmcgowan merged commit 34d83e1 into containerd:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@helen-frank @k8s-ci-robot @dmcgowan @estesp