Extract CRI instrument into separate package#8093
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Feb 13, 2023
Merged
Conversation
mxpv
changed the title
Member
Author
|
/test pull-containerd-sandboxed-node-e2e |
dmcgowan
reviewed
Feb 13, 2023
Signed-off-by: Maksym Pavlenko <[email protected]>
AkihiroSuda
approved these changes
Feb 13, 2023
dmcgowan
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRI is probably one of the largest plugins/packages in containerd.
It'd preferable to move towards a set of smaller / easier to maintain packages/plugins, same as the majority of the other plugins we currently maintain in containerd project.
This PR extracts instrumentation code from
cri/into a separate go package, so both CRI and sandboxes CRI can depend and reuse it.Signed-off-by: Maksym Pavlenko [email protected]