Skip to content

chore: clean up repeated package import#8078

Merged
fuweid merged 1 commit intocontainerd:mainfrom
Fish-pro:chore/package
Feb 10, 2023
Merged

chore: clean up repeated package import#8078
fuweid merged 1 commit intocontainerd:mainfrom
Fish-pro:chore/package

Conversation

@Fish-pro
Copy link
Copy Markdown

@Fish-pro Fish-pro commented Feb 10, 2023

Signed-off-by: Zechun Chen [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @Fish-pro. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fish-pro
Copy link
Copy Markdown
Author

@dmcgowan

I understand it is a network problem. Could you please re-run the error job, thanks

image

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Feb 10, 2023

@Fish-pro Would you use your real-name in sign-off? Thanks

@Fish-pro
Copy link
Copy Markdown
Author

@Fish-pro Would you use your real-name in sign-off? Thanks

@fuweid Must I use my real-name? My email address can advance my real-name,can I keep my current sign-off?

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Feb 10, 2023

https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

Use your real name (sorry, no pseudonyms or anonymous contributions.)

@Fish-pro Yes. Please use real-name. Thanks

@Fish-pro
Copy link
Copy Markdown
Author

https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

Use your real name (sorry, no pseudonyms or anonymous contributions.)

@Fish-pro Yes. Please use real-name. Thanks

@fuweid Thanks for tips,I have modified it.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@fuweid fuweid merged commit 4c44ec7 into containerd:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants