Skip to content

chore: use http constants instead of string#8077

Merged
mxpv merged 1 commit intocontainerd:mainfrom
Fish-pro:chore/httpvar
Feb 10, 2023
Merged

chore: use http constants instead of string#8077
mxpv merged 1 commit intocontainerd:mainfrom
Fish-pro:chore/httpvar

Conversation

@Fish-pro
Copy link
Copy Markdown

@Fish-pro Fish-pro commented Feb 10, 2023

Signed-off-by: Fish-pro [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 10, 2023

Hi @Fish-pro. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 10, 2023

@Fish-pro: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fish-pro
Copy link
Copy Markdown
Author

Fish-pro commented Feb 10, 2023

@dmcgowan

Some jobs error，could you please give me some guidance?

image

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Feb 10, 2023

I'll re-run, filed #8079 since I didn't see an existing issue for that failure.

@Fish-pro
Copy link
Copy Markdown
Author

Fish-pro commented Feb 10, 2023

I'll re-run, filed #8079 since I didn't see an existing issue for that failure.

Tkanks for your guidance

@mxpv mxpv merged commit 195eca1 into containerd:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fish-pro @k8s-ci-robot @dmcgowan @samuelkarp @mxpv