Skip to content

Add critest.exe in $PATH#8074

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
kzys:fix-8073
Feb 9, 2023
Merged

Add critest.exe in $PATH#8074
samuelkarp merged 1 commit intocontainerd:mainfrom
kzys:fix-8073

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Feb 9, 2023

The binary location was moved since
kubernetes-sigs/cri-tools#1085.

Fixes #8073.

Signed-off-by: Kazuyoshi Kato [email protected]

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

The binary location was moved since
kubernetes-sigs/cri-tools#1085.

Fixes containerd#8073.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@samuelkarp samuelkarp merged commit 26509fa into containerd:main Feb 9, 2023
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows CI: critest.exe not recognized

4 participants