Skip to content

Clean CI yaml#8071

Merged
AkihiroSuda merged 2 commits intocontainerd:mainfrom
mxpv:cleanup
Feb 10, 2023
Merged

Clean CI yaml#8071
AkihiroSuda merged 2 commits intocontainerd:mainfrom
mxpv:cleanup

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Feb 9, 2023

Signed-off-by: Maksym Pavlenko [email protected]

@sbuckfelder
Copy link
Copy Markdown

Why can the code in github/workflows/ci.yml be safely deleted?

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Feb 9, 2023

Why can the code in github/workflows/ci.yml be safely deleted?

@sbuckfelder containerd no longer needs to be in GOPATH to produce binaries.
It's in the past for a while.
The only place we still need it is protobuf code generator.

@kzys
Copy link
Copy Markdown
Member

kzys commented Feb 9, 2023

Re-running failed jobs...

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Feb 9, 2023

Looks like Windows integration tests got broken.
Seeing the same error in #8072

mxpv added 2 commits February 9, 2023 15:30
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Feb 9, 2023

Rebased against main to include changes from #8074

@AkihiroSuda AkihiroSuda merged commit a6f3cbe into containerd:main Feb 10, 2023
@mxpv mxpv deleted the cleanup branch February 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants