pkg/cri/config: fix Mirrors deprecation comment #8041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yankay. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yankay
changed the title
yankay
changed the title
yankay
changed the title
yankay
force-pushed
the
fix-mistack-docs
branch
5 times, most recently
from
b0b074a to
0f13159
Compare
Member
|
cc @mikebrow |
yankay
force-pushed
the
fix-mistack-docs
branch
from
0f13159 to
4ebc82f
Compare
Member
|
nit: there are two minor errors in the commit message
Mind fixing those? |
yankay
changed the title
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
fix-mistack-docs
branch
from
4ebc82f to
0b33a45
Compare
Contributor
Author
|
Thanks @samuelkarp for the PR review, it has changed :-) |
samuelkarp
approved these changes
Feb 7, 2023
dmcgowan
approved these changes
Feb 15, 2023
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config registry mirror is still in version 1.7 and may plan to delete at 2.0
”Removal of this and other deprecations are not immediate. Yes, we've been considering removing all v1 deprecations when we move to v2, yes perhaps EOY perhaps sometime next year. We've been discussing the possibility of providing migration tooling for config and metadata. It is just as likely we will attempt to carry v1 and early v2 release versions of certain services (esp. CRI) at the same time to allow for opt in testing. The hosts.toml config is very similar to docker hosts.toml, if that helps.
"
from the kubernetes/kubernetes#110312 (comment)_
And https://github.com/containerd/containerd/blame/main/docs/cri/registry.md#L14 is also showd " remove in containerd 2.0"
The comments may mislead the developers, such as kubespray, so fix it.
If the PR is wrong, please comment on it, thank you very much.
Signed-off-by: Kay Yan [email protected]