Skip to content

cmd/ctr/commands: clean up the func IntToInt32Array in utils.go#8039

Merged
estesp merged 1 commit intocontainerd:mainfrom
yankay:cleanup-useless-IntToInt32Array-func
Feb 1, 2023
Merged

cmd/ctr/commands: clean up the func IntToInt32Array in utils.go#8039
estesp merged 1 commit intocontainerd:mainfrom
yankay:cleanup-useless-IntToInt32Array-func

Conversation

@yankay
Copy link
Copy Markdown
Contributor

@yankay yankay commented Feb 1, 2023

This PR is to clean up the func IntToInt32Array in utils.go.

The func is not used in containerd anymore, so clean up it.

Signed-off-by: Kay Yan [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 1, 2023

Hi @yankay. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yankay yankay force-pushed the cleanup-useless-IntToInt32Array-func branch from 6a6c752 to 565f2bf Compare February 1, 2023 04:10
@yankay yankay force-pushed the cleanup-useless-IntToInt32Array-func branch from 565f2bf to 2f1aad0 Compare February 1, 2023 04:14
estesp
estesp approved these changes Feb 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thaJeztah
thaJeztah approved these changes Feb 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit eda0792 into containerd:main Feb 1, 2023
@yankay
Copy link
Copy Markdown
Contributor Author

yankay commented Feb 2, 2023 •
edited
Loading

Thanks @thaJeztah @estesp for the PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yankay @k8s-ci-robot @estesp @thaJeztah