Skip to content

Adding support to run install hcsshim from local clone #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 2 commits into from
Feb 2, 2023
Merged

Adding support to run install hcsshim from local clone #7989

fuweid merged 2 commits into from
Feb 2, 2023

Conversation

@mohitsharma-in
Copy link
Contributor

@mohitsharma-in mohitsharma-in commented Jan 24, 2023

Adding support to run install hcsshim from the local clone. If local not available the clone from the repo.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 24, 2023

Hi @mohitsharma-in. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kzys
kzys approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. You need Signed-off-by like. https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

kevpar
kevpar approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitsharma-in mohitsharma-in force-pushed the topic/directory-install-runhcs-shim branch from 0a3da80 to cfb0bda Compare January 27, 2023 11:26
@mohitsharma-in mohitsharma-in force-pushed the topic/directory-install-runhcs-shim branch from cfb0bda to 77e51e9 Compare January 27, 2023 11:27
fuweid
fuweid reviewed Jan 30, 2023
View reviewed changes
estesp
estesp approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 6ed24c8 into containerd:main Feb 2, 2023
@akhilerm akhilerm mentioned this pull request Jun 20, 2023
Merged
@fuweid fuweid added the cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@kevpar kevpar kevpar approved these changes

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch needs-ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mohitsharma-in @k8s-ci-robot @kzys @kevpar @estesp @fuweid @dcantah