test: add hostNetwork tests for both windows and linux#7984
test: add hostNetwork tests for both windows and linux#7984dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @aitumik. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
A few comments:
|
|
This should resolve #7826 |
@aitumik If this was confusing, we split the CRI codebase in two while we work on an experimental feature here. This is where you'd need to duplicate your changes: https://github.com/containerd/containerd/tree/main/pkg/cri/sbserver. It should be a pretty easy copy and paste for that and the files are named the same. Thanks for working on this! |
0f2b7b0 to
0d1a94f
Compare
|
Could you pls squash the commits? |
|
/test pull-containerd-sandboxed-node-e2e |
0d1a94f to
ed9e747
Compare
| } | ||
|
|
||
| for _, tt := range tests { | ||
| if goruntime.GOOS != "windows" { |
There was a problem hiding this comment.
Do we need this check? Go should exclude _windows_test.go on non-Windows platforms.
There was a problem hiding this comment.
No we don't need it actually. It is implicit in the filename making the changes..
dcantah
left a comment
There was a problem hiding this comment.
Same comment as Maksym, otherwise LGTM
36d039d to
57645d4
Compare
|
Can you try a rebase to see if we can get the windows tests passing. The errors don't seem related to your change, but I don't quite understand the failure either. |
fb0cf63 to
0003939
Compare
Signed-off-by: Nathan <[email protected]>
0003939 to
7cf5560
Compare
Add the following tests for
hostNetworkhelper functionPodSandboxConfighostNetwork returns truePodSandboxConfighostNetwork returns falsehostNetworkreturns falsehostNetworkreturns true