Skip to content

Update CNI plugins to 1.2.0#7977

Merged
fuweid merged 1 commit intocontainerd:mainfrom
adisky:update-cni-version
Jan 30, 2023
Merged

Update CNI plugins to 1.2.0#7977
fuweid merged 1 commit intocontainerd:mainfrom
adisky:update-cni-version

Conversation

@adisky
Copy link
Copy Markdown
Contributor

@adisky adisky commented Jan 19, 2023

@k8s-ci-robot
Copy link
Copy Markdown

Hi @adisky. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adisky adisky force-pushed the update-cni-version branch 2 times, most recently from 842442d to 2c8a906 Compare January 19, 2023 10:15
@dcantah
Copy link
Copy Markdown
Member

dcantah commented Jan 19, 2023

@adisky You'll need to do a go mod tidy in /integration/client as well. Thanks!

@adisky
Copy link
Copy Markdown
Contributor Author

adisky commented Jan 20, 2023

@dcantah I already ran, but something is messing it, will take another look today

@adisky adisky force-pushed the update-cni-version branch 4 times, most recently from af2242e to 5704b66 Compare January 23, 2023 12:20
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jan 30, 2023

@adisky would you please fix the conflict? Thanks!

Signed-off-by: Aditi <[email protected]>
@adisky adisky force-pushed the update-cni-version branch from 5704b66 to 7ec75b1 Compare January 30, 2023 10:26
@adisky
Copy link
Copy Markdown
Contributor Author

adisky commented Jan 30, 2023

@fuweid updated

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jan 30, 2023

=== FAIL: . TestContainerUsername (0.14s)
    log_hook.go:47: time="2023-01-30T10:44:59.460404889Z" level=debug msg="remote introspection plugin filters" func="introspection.(*introspectionRemote).Plugins" file="/home/runner/work/containerd/containerd/services/introspection/introspection.go:46" filters="[type==io.containerd.snapshotter.v1, id==overlayfs]"
    container_test.go:2524: expected www-data uid to be 33 but received ""

Unexpected fail. Reruning.

@fuweid fuweid merged commit c3e2361 into containerd:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants