btrfs: depend on kernel UAPI instead of libbtrfs#7933
Merged
estesp merged 1 commit intocontainerd:mainfrom Feb 10, 2023
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
AkihiroSuda
force-pushed
the
drop-libbtrfs
branch
3 times, most recently
from
ac8d6b2 to
ba2e2f7
Compare
See containerd/btrfs PR 40 and moby/moby PR 44761. (Thanks to [@]neersighted.) The containerd/btrfs library now requires headers from kernel 4.12 or newer: - https://github.com/torvalds/linux/blob/master/include/uapi/linux/btrfs.h - https://github.com/torvalds/linux/blob/master/include/uapi/linux/btrfs_tree.h These files are licensed under the GPL-2.0 WITH Linux-syscall-note, so it should be compatible with the Apache License 2.0. https://spdx.org/licenses/Linux-syscall-note.html The dependency on the kernel headers only affects users building from source. Users on older kernels may opt to not compile this library (`BUILDTAGS=no_btfs`), or to provide headers from a newer kernel. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
drop-libbtrfs
branch
from
ba2e2f7 to
52f82ac
Compare
neersighted
approved these changes
Feb 10, 2023
dmcgowan
approved these changes
Feb 10, 2023
dims
approved these changes
Feb 10, 2023
Member
dims
left a comment
dims
left a comment
There was a problem hiding this comment.
Most of the changes are in vendor/ so all good here with the changes in the rest of the files (yaml files for CI, go mod/sum etc)
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See containerd/btrfs#40 and moby/moby#44761. (Thanks to @neersighted.)
The containerd/btrfs library now requires headers from kernel 4.12 or newer:
These files are licensed under the GPL-2.0 WITH Linux-syscall-note, so it should be compatible with the Apache License 2.0. https://spdx.org/licenses/Linux-syscall-note.html
The dependency on the kernel headers only affects users building from source. Users on older kernels may opt to not compile this library (
BUILDTAGS=no_btfs), or to provide headers from a newer kernel.