Refactor snapshotters metastore transaction #7917
Conversation
|
Hi @iyear. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
iyear
changed the title
There's the Windows and lcow snapshotters as well |
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Thanks for this, I like how these are turning out
snapshots/native/native.go
Outdated
| } | ||
| usage = snapshots.Usage(du) | ||
|
|
||
| if info.Kind == snapshots.KindActive { |
There was a problem hiding this comment.
Possible optimization after this PR, move the fs.DiskUsage call outside the transaction, it can be really slow
There was a problem hiding this comment.
It's a small bug, I fixed it directly...
|
I'll commit the rest of the refactoring later, goland's usage search automatically ignores non-native platform go files, so I didn't search for windows-related snapshotters. |
|
No worries! |
Signed-off-by: Junyu Liu <[email protected]>
|
The remaining snapshotters have been refactored. |
|
Re-requested/dismissed our reviews as you ported two other snapshotters in here now. Will try and get to this this week! |
… main Updates ADO containerd fork-external/main with upstream containerd main @commit hash: f9f8455 containerd@f9f8455 Additional changes in the PR: - update linux container image version - remove copying LICENSE file in shared-build-stages.yml - additions to .gdnsuppress Related work items: containerd#5674, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7879, containerd#7880, containerd#7881, containerd#7882, containerd#7883, containerd#7886, containerd#7887, containerd#7888, containerd#7891, containerd#7892, containerd#7893, containerd#7894, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7960, containerd#7963, containerd#7969, containerd#7970, containerd#7973
…/main Update fork-external/main with upstream containerd/containerd/main at commit hash 3d32da8 Related work items: containerd#5674, containerd#7129, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7882, containerd#7883, containerd#7886, containerd#7891, containerd#7892, containerd#7893, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7959, containerd#7960, containerd#7963, containerd#7968, containerd#7969, containerd#7970, containerd#7973, containerd#7985, containerd#7987, containerd#7994, containerd#8005
5 participants
Signed-off-by: Junyu Liu [email protected]
close #7528
close #7915
It seems that only
nativeis remaining.