Skip to content

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jan 1, 2023

Fix #7889


Additional commit container_stats_test.go: avoid checking snapshot size

The snapshot size is no longer tested in container_stats_test.go, due to

Additional commit TestVolumeOwnership: compare GID, not group name

The name of the GID 65534 differs across distros.
("nogroup" on Debian derivatives, "nobody" on Red Hat derivatives)

Additional commit cri-integration: set SelinuxRelabel

Enable SELinux relabeling

Additional commit nri_test.go: skip if SELinux is enabled

SELinux relabeling does not seem implemented for NRI yet
containerd/nri#16 (comment)

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch 8 times, most recently from 94cae75 to eccef13 Compare January 2, 2023 03:26
@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda AkihiroSuda changed the title cgroup v2 CI: enable cri-integration cirrus CI (Fedora 37, Rocky 8): enable cri-integration Jan 2, 2023
@AkihiroSuda AkihiroSuda changed the title cirrus CI (Fedora 37, Rocky 8): enable cri-integration Cirrus CI (Fedora 37, Rocky 8): enable cri-integration Jan 2, 2023
@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch from eccef13 to 2582718 Compare January 3, 2023 12:04
@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch 3 times, most recently from 10d43ad to bd15920 Compare January 3, 2023 14:01
@AkihiroSuda AkihiroSuda changed the title Cirrus CI (Fedora 37, Rocky 8): enable cri-integration Cirrus CI (Fedora 37, Rocky 8): enable cri-integration; container_stats_test.go: avoid checking snapshot size Jan 3, 2023
@AkihiroSuda AkihiroSuda changed the title Cirrus CI (Fedora 37, Rocky 8): enable cri-integration; container_stats_test.go: avoid checking snapshot size Cirrus CI (Fedora 37, Rocky 8): enable cri-integration Jan 3, 2023
@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch from 839bf2e to 46359ac Compare January 3, 2023 14:53
@AkihiroSuda

This comment was marked as resolved.

@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch 2 times, most recently from 28916c4 to fe96373 Compare January 3, 2023 15:31
On Linux, the snapshot size differs depending on the backing filesystem.
See issue 7909.

Signed-off-by: Akihiro Suda <[email protected]>
The name of the GID 65534 differs across distros.
("nogroup" on Debian derivatives, "nobody" on Red Hat derivatives)

Fix the following test failure:
```
=== RUN   TestVolumeOwnership
    volume_copy_up_test.go:103: Create a sandbox
    main_test.go:667: Pull test image "ghcr.io/containerd/volume-ownership:2.1"
    volume_copy_up_test.go:108: Create a container with volume-ownership test image
    volume_copy_up_test.go:117: Start the container
    volume_copy_up_test.go:125: Check ownership of test directory inside container
    volume_copy_up_test.go:146: Check ownership of test directory on the host
    volume_copy_up_test.go:153:
        	Error Trace:	/root/go/src/github.com/containerd/containerd/volume_copy_up_test.go:153
        	Error:      	Not equal:
        	            	expected: "nobody:nogroup\n"
        	            	actual  : "nobody:nobody\n"

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-nobody:nogroup
        	            	+nobody:nobody

        	Test:       	TestVolumeOwnership
--- FAIL: TestVolumeOwnership (3.45s)
```

Signed-off-by: Akihiro Suda <[email protected]>
SELinux relabeling is not implemented for NRI yet

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the cri-integration-cgroup2 branch from fe96373 to 419b5ab Compare January 3, 2023 17:20
@AkihiroSuda AkihiroSuda marked this pull request as ready for review January 3, 2023 17:21
@AkihiroSuda
Copy link
Member Author

/test all

@AkihiroSuda AkihiroSuda added the area/cri Container Runtime Interface (CRI) label Jan 3, 2023
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 28e8e24 into containerd:main Jan 4, 2023
fangn2 added a commit to fangn2/containerd that referenced this pull request Jan 9, 2023
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
jsturtevant pushed a commit to jsturtevant/containerd that referenced this pull request Sep 21, 2023
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Mar 5, 2024
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
(cherry picked from commit 82d6c2f)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Mar 6, 2024
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
(cherry picked from commit 82d6c2f)
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez pushed a commit to austinvazquez/containerd that referenced this pull request Mar 7, 2024
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
(cherry picked from commit 82d6c2f)
Signed-off-by: Austin Vazquez <[email protected]>
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
…ation test failure

PR containerd#7892 which supposed to fix issue on Linux introduced random failure
on Windows, this commit is to revert that change for Windows platform

Signed-off-by: Tony Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) kind/test

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

cgroup v2 CI lacks cri-integration

4 participants