Cirrus CI (Fedora 37, Rocky 8): enable cri-integration#7892
Merged
fuweid merged 5 commits intocontainerd:mainfrom Jan 4, 2023
Merged
Cirrus CI (Fedora 37, Rocky 8): enable cri-integration#7892fuweid merged 5 commits intocontainerd:mainfrom
fuweid merged 5 commits intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
8 times, most recently
from
94cae75 to
eccef13
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
changed the title
AkihiroSuda
changed the title
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
from
eccef13 to
2582718
Compare
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
3 times, most recently
from
10d43ad to
bd15920
Compare
AkihiroSuda
changed the title
AkihiroSuda
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
from
839bf2e to
46359ac
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
2 times, most recently
from
28916c4 to
fe96373
Compare
On Linux, the snapshot size differs depending on the backing filesystem. See issue 7909. Signed-off-by: Akihiro Suda <[email protected]>
The name of the GID 65534 differs across distros.
("nogroup" on Debian derivatives, "nobody" on Red Hat derivatives)
Fix the following test failure:
```
=== RUN TestVolumeOwnership
volume_copy_up_test.go:103: Create a sandbox
main_test.go:667: Pull test image "ghcr.io/containerd/volume-ownership:2.1"
volume_copy_up_test.go:108: Create a container with volume-ownership test image
volume_copy_up_test.go:117: Start the container
volume_copy_up_test.go:125: Check ownership of test directory inside container
volume_copy_up_test.go:146: Check ownership of test directory on the host
volume_copy_up_test.go:153:
Error Trace: /root/go/src/github.com/containerd/containerd/volume_copy_up_test.go:153
Error: Not equal:
expected: "nobody:nogroup\n"
actual : "nobody:nobody\n"
Diff:
--- Expected
+++ Actual
@@ -1,2 +1,2 @@
-nobody:nogroup
+nobody:nobody
Test: TestVolumeOwnership
--- FAIL: TestVolumeOwnership (3.45s)
```
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
SELinux relabeling is not implemented for NRI yet Signed-off-by: Akihiro Suda <[email protected]>
Fix issue 7889 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
cri-integration-cgroup2
branch
from
fe96373 to
419b5ab
Compare
Member
Author
|
/test all |
fuweid
approved these changes
Jan 4, 2023
fangn2
added a commit
to fangn2/containerd
that referenced
this pull request
Jan 9, 2023
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]>
This was referenced Jan 9, 2023
jsturtevant
pushed a commit
to jsturtevant/containerd
that referenced
this pull request
Sep 21, 2023
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]>
austinvazquez
pushed a commit
to austinvazquez/containerd
that referenced
this pull request
Mar 5, 2024
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]> (cherry picked from commit 82d6c2f) Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
pushed a commit
to austinvazquez/containerd
that referenced
this pull request
Mar 6, 2024
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]> (cherry picked from commit 82d6c2f) Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
pushed a commit
to austinvazquez/containerd
that referenced
this pull request
Mar 7, 2024
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]> (cherry picked from commit 82d6c2f) Signed-off-by: Austin Vazquez <[email protected]>
kiashok
pushed a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
…ation test failure PR containerd#7892 which supposed to fix issue on Linux introduced random failure on Windows, this commit is to revert that change for Windows platform Signed-off-by: Tony Fang <[email protected]>
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
… main Updates ADO containerd fork-external/main with upstream containerd main @commit hash: f9f8455 containerd@f9f8455 Additional changes in the PR: - update linux container image version - remove copying LICENSE file in shared-build-stages.yml - additions to .gdnsuppress Related work items: containerd#5674, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7879, containerd#7880, containerd#7881, containerd#7882, containerd#7883, containerd#7886, containerd#7887, containerd#7888, containerd#7891, containerd#7892, containerd#7893, containerd#7894, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7960, containerd#7963, containerd#7969, containerd#7970, containerd#7973
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
…/main Update fork-external/main with upstream containerd/containerd/main at commit hash 3d32da8 Related work items: containerd#5674, containerd#7129, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7882, containerd#7883, containerd#7886, containerd#7891, containerd#7892, containerd#7893, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7959, containerd#7960, containerd#7963, containerd#7968, containerd#7969, containerd#7970, containerd#7973, containerd#7985, containerd#7987, containerd#7994, containerd#8005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7889
Additional commit
container_stats_test.go: avoid checking snapshot sizeThe snapshot size is no longer tested in
container_stats_test.go, due toUsage()result differs across ext4 and XFS #7909Additional commit
TestVolumeOwnership: compare GID, not group nameThe name of the GID 65534 differs across distros.
("nogroup" on Debian derivatives, "nobody" on Red Hat derivatives)
Additional commit
cri-integration: set SelinuxRelabelEnable SELinux relabeling
Additional commit
nri_test.go: skip if SELinux is enabledSELinux relabeling does not seem implemented for NRI yet
containerd/nri#16 (comment)