Skip to content

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jan 1, 2023

Saw rate limit errors locally (not on CI)

@dmcgowan
Copy link
Member

dmcgowan commented Jan 2, 2023

Do we want to pin versions here instead of using the latest? For the mirror, the latest tag still needs to be triggered manually. This change will pin us on images published a year ago, where as today it is using recent images. I'm not sure how much it matters for the tests using these though.

@AkihiroSuda
Copy link
Member Author

Do we want to pin versions here instead of using the latest? For the mirror, the latest tag still needs to be triggered manually. This change will pin us on images published a year ago, where as today it is using recent images. I'm not sure how much it matters for the tests using these though.

I’d say yes, for better reproducibility of the test results.

@dmcgowan
Copy link
Member

dmcgowan commented Jan 2, 2023

Ok, We can always update it later manually after we trigger the mirror.

@dmcgowan dmcgowan merged commit 1d43149 into containerd:main Jan 2, 2023
@dmcgowan dmcgowan added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch easy-to-review Easy to review kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants