Skip to content

CRI sbserver: Prevent server reuse after Shutdown#7872

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
yanggangtony:cri-sbserver
Dec 27, 2022
Merged

CRI sbserver: Prevent server reuse after Shutdown#7872
dmcgowan merged 1 commit intocontainerd:mainfrom
yanggangtony:cri-sbserver

Conversation

@yanggangtony
Copy link
Copy Markdown
Contributor

@yanggangtony yanggangtony commented Dec 27, 2022

Signed-off-by: yanggang [email protected]

Like pkg/cri/server/service.go commit , I have no idea why not commit this one, like pkg/cri/sbserver/service.go
They may be the same logic..
😰😰
If mine understanding is wrong , please tell me...

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Dec 27, 2022

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcantah
dcantah approved these changes Dec 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not missing anything afaict, we just missed copying this to the sandbox server here looks like. Thanks! LGTM

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Dec 27, 2022

@yanggangtony Can you prefix the title and commit with 'CRI sbserver:' to make this identifiable as a sandbox server change? So "CRI sbserver: Prevent server reuse after Shutdown" or similar.

@yanggangtony yanggangtony changed the title prevent Server reuse after a Shutdown CRI sbserver: prevent Server reuse after a Shutdown Dec 27, 2022
@yanggangtony yanggangtony changed the title CRI sbserver: prevent Server reuse after a Shutdown CRI sbserver: Prevent server reuse after Shutdown Dec 27, 2022
@yanggangtony
Copy link
Copy Markdown
Contributor Author

yanggangtony commented Dec 27, 2022

@yanggangtony Can you prefix the title and commit with 'CRI sbserver:' to make this identifiable as a sandbox server change? So "CRI sbserver: Prevent server reuse after Shutdown" or similar.

Thanks for review.
Done it..

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Dec 27, 2022

I didn't follow the change. Does it actually prevent server resue after Shutdown?

@yanggangtony
Copy link
Copy Markdown
Contributor Author

yanggangtony commented Dec 27, 2022

@fuweid
The original is net/http: prevent Server reuse after a Shutdown.
And the before time merged is by pkg/cri/server/service.go .
Actually i have not test that one.
I just keep the code style keep same.:grinning:

@dmcgowan dmcgowan merged commit 27f4350 into containerd:main Dec 27, 2022
@yanggangtony yanggangtony deleted the cri-sbserver branch November 25, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanggangtony @k8s-ci-robot @dcantah @fuweid @dmcgowan