Avoid using canceled context in unpacker cleanup #7859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <[email protected]>
fuweid
reviewed
Dec 23, 2022
| select { | ||
| case <-ctx.Done(): | ||
| abort() | ||
| abort(context.Background()) // Cleanup context |
Member
There was a problem hiding this comment.
I am wonder that the ctx won't work if the client doesn't set default namespace.
Maybe we can extract namespace from orignal contxt and set it into cleanup context?
Member
Author
There was a problem hiding this comment.
After this change I was playing around with #7861
samuelkarp
approved these changes
Dec 23, 2022
kzys
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5314