Check containerd's readiness before calling critest#7851
Merged
samuelkarp merged 1 commit intocontainerd:mainfrom Dec 22, 2022
Merged
Check containerd's readiness before calling critest#7851samuelkarp merged 1 commit intocontainerd:mainfrom
samuelkarp merged 1 commit intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
critest-wait
branch
5 times, most recently
from
dd2a295 to
25e062e
Compare
fuweid
reviewed
Dec 22, 2022
| # Make sure containerd is ready before calling critest. | ||
| for i in $(seq 1 10) | ||
| do | ||
| /usr/local/bin/ctr -a ${BDIR}/c.sock version && break || sleep 1 |
Member
There was a problem hiding this comment.
suggest to use crictl info because containerd cri plugin needs time to setup.
It was assuming containerd was ready right after starting. But it depends GitHub actions' performance. In addition to that, this commit extracts the script from ci.yml. Signed-off-by: Kazuyoshi Kato <[email protected]>
dmcgowan
approved these changes
Dec 22, 2022
samuelkarp
approved these changes
Dec 22, 2022
mikebrow
reviewed
Dec 22, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
see https://github.com/containerd/containerd/blob/main/script/test/utils.sh note readiness check for ctr and crictl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was assuming containerd was ready right after starting.
But it depends GitHub actions' performance.
In addition to that, this commit extracts the script from ci.yml.
Signed-off-by: Kazuyoshi Kato [email protected]