Skip to content

Fix grammatical errors in Readme#7837

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
MarkintoshZ:main
Dec 22, 2022
Merged

Fix grammatical errors in Readme#7837
samuelkarp merged 1 commit intocontainerd:mainfrom
MarkintoshZ:main

Conversation

@MarkintoshZ
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @MarkintoshZ. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Dec 19, 2022

Please sign-off on your commit and re-push. git commit --amend -s

@MarkintoshZ MarkintoshZ force-pushed the main branch 2 times, most recently from f4d1fb8 to 6ffb256 Compare December 19, 2022 04:54
Comment thread README.md Outdated
- If the issue has not already been assigned to someone, or has not made recent progress and you are interested, please inquire.
- If you are interested in starting with a smaller / beginner level issue, look for issues with an `exp/beginner` tag, for example [containerd/containerd beginner issues.](https://github.com/containerd/containerd/issues?q=is%3Aissue+is%3Aopen+label%3Aexp%2Fbeginner)
- If the issue has not already been assigned to someone or has not made recent progress and you are interested, please inquire.
- If you are interested in starting with a smaller / beginner-level issue, look for issues with an `exp/beginner` tag, for example [containerd/containerd beginner issues.](https://github.com/containerd/containerd/issues?q=is%3Aissue+is%3Aopen+label%3Aexp%2Fbeginner)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did the same for the others so lets do smaller/beginner-level here (no space between).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Dec 22, 2022

@MarkintoshZ You mind squashing the commits? Then I think we're good here.

@MarkintoshZ
Copy link
Copy Markdown
Contributor Author

Great! Just squashed it!

@samuelkarp samuelkarp merged commit 46b706a into containerd:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants