Skip to content

Revert "[release/1.6] support fetching containerd from non public GCS buckets"#7830

Merged
kzys merged 1 commit intocontainerd:release/1.6from
akhilerm:revert-7823-cherry-pick-7771-1.6
Dec 16, 2022
Merged

Revert "[release/1.6] support fetching containerd from non public GCS buckets"#7830
kzys merged 1 commit intocontainerd:release/1.6from
akhilerm:revert-7823-cherry-pick-7771-1.6

Conversation

@akhilerm
Copy link
Copy Markdown
Member

@akhilerm akhilerm commented Dec 16, 2022 •
edited
Loading

Reverts #7823

The changes is causing continuous failure in containerd-node-e2e-1.6 and containerd-node-e2e-features-1.6, because the actual blob is not getting downloaded as per logs

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Dec 16, 2022

Hi @akhilerm. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm akhilerm force-pushed the revert-7823-cherry-pick-7771-1.6 branch from 0b9a713 to e8b22c1 Compare December 16, 2022 17:08
@akhilerm
Copy link
Copy Markdown
Member Author

akhilerm commented Dec 16, 2022

/cc @dmcgowan .

can you give an ok-to-test on the PR.

@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 16, 2022

/ok-to-test

estesp
estesp approved these changes Dec 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 07b839d into containerd:release/1.6 Dec 16, 2022
@akhilerm akhilerm deleted the revert-7823-cherry-pick-7771-1.6 branch December 17, 2022 01:46
@dmcgowan dmcgowan mentioned this pull request Dec 19, 2022
Merged
@akhilerm akhilerm mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akhilerm @k8s-ci-robot @estesp @kzys