Remove github.com/gogo/protobuf again#7825
Merged
fuweid merged 2 commits intocontainerd:mainfrom Dec 16, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
no-gogo
branch
4 times, most recently
from
84e563f to
9b672c4
Compare
estesp
approved these changes
Dec 15, 2022
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM, but one nit about indirect deps in the "main" clause of go.mod
| github.com/emicklei/go-restful/v3 v3.8.0 | ||
| github.com/fsnotify/fsnotify v1.6.0 | ||
| github.com/gogo/protobuf v1.3.2 | ||
| github.com/gogo/protobuf v1.3.2 // indirect |
Member
There was a problem hiding this comment.
nit, we usually move indirect deps in the next "indirect" collection to make it clearer
Member
Author
There was a problem hiding this comment.
Hmm maybe my Go toolchain is old? Let me check.
added 2 commits
December 15, 2022 22:54
While we need to support CRI v1alpha2, the implementation doesn't have to be tied to gogo/protobuf. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
dmcgowan
approved these changes
Dec 16, 2022
fuweid
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we need to support CRI v1alpha2, the implementation doesn't have to be tied to gogo/protobuf.
Signed-off-by: Kazuyoshi Kato [email protected]