CRI: Add host networking helper#7814
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Dec 15, 2022
Merged
Conversation
Member
Author
|
There's a comment about having shared helpers between sbserver and the standard CRI server somewhere in the codebase after the main functionality is all there, that'd be lovely for this 😆 |
We do a ton of host networking checks around the CRI plugin, all mainly doing the same thing of checking the different quirks on various platforms (for windows are we a HostProcess pod, for linux is namespace mode the right thing, darwin doesn't have CNI support etc.) which could all be bundled up into a small helper that can be re-used. Signed-off-by: Danny Canter <[email protected]>
dcantah
force-pushed
the
hostnet-helper
branch
from
68e3779 to
8452907
Compare
Member
|
/test pull-containerd-sandboxed-node-e2e |
dmcgowan
approved these changes
Dec 15, 2022
kzys
approved these changes
Dec 15, 2022
Member
|
Looks good to me. Will wait the folks @mikebrow has assigned. |
mxpv
approved these changes
Dec 15, 2022
mikebrow
approved these changes
Dec 15, 2022
MikeZappa87
approved these changes
Dec 15, 2022
Member
MikeZappa87
left a comment
MikeZappa87
left a comment
There was a problem hiding this comment.
It would be great to hear the plans for container networking for darwin.
Member
Author
Will do |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do a ton of host networking checks around the CRI plugin, all mainly doing the same thing of checking the different quirks on various platforms (for windows are we a HostProcess pod, for linux is namespace mode the right thing, darwin doesn't have CNI support etc.) which could all be bundled up into a small helper that can be re-used.