Skip to content

Conversation

@lucacome
Copy link
Contributor

Changes:

  • Bumps the version of Go to 1.19
  • Updates CI to read the version of Go from go.mod

Go 1.19 is required for #7803 (see here)

@k8s-ci-robot
Copy link

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucacome lucacome force-pushed the bump-go-1.19 branch 2 times, most recently from ecf8643 to 971d150 Compare December 14, 2022 08:25
Signed-off-by: Luca Comellini <[email protected]>
@estesp
Copy link
Member

estesp commented Dec 14, 2022

I think this needs some discussion:

  • we currently control updates to minor version releases of Go; especially as we reach release milestones, we don't want the minor version to change automatically between test and release. Using the go.mod file approach doesn't allow us to do this.
  • we are currently still supporting building 1.7 with Go 1.18.x; we need to discuss and agree to drop that support before we can adopt these changes (or more specifically, update the k8s vendoring to code that can only build with Go 1.19+)

Regardless, I think we want to support the last 2 versions of Go, so even when Go 1.19 is superseded by Go 1.20, I believe we will still want our matrix definition of versions in the GitHub actions CI workflow, so I don't think the go.mod based version definition in CI is the right model for us.

Of course, this is just my opinion. Need the rest of @containerd/committers to offer their opinions.

Also, the name of the PR is confusing given the existence of Go 1.19 used everywhere in our CI and release process :) Maybe you mean "Remove Go 1.18 support"

@dmcgowan dmcgowan added the status/needs-discussion Needs discussion and decision from maintainers label Dec 22, 2022
@fuweid
Copy link
Member

fuweid commented Feb 16, 2023

close by #8109

@fuweid fuweid closed this Feb 16, 2023
@lucacome
Copy link
Contributor Author

@fuweid that doesn’t really bump the version…

@lucacome lucacome deleted the bump-go-1.19 branch February 16, 2023 22:53
@fuweid
Copy link
Member

fuweid commented Feb 17, 2023

@lucacome sorry for the mistake. :( Please feel free to file other pr to upgrade the version in go.mod. Sorry for any inconvenience!

@AkihiroSuda
Copy link
Member

Already updated in #8103
281f89a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test status/needs-discussion Needs discussion and decision from maintainers

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants