-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Bump Go to 1.19 #7813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to 1.19 #7813
Conversation
|
Hi @lucacome. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ecf8643 to
971d150
Compare
Signed-off-by: Luca Comellini <[email protected]>
971d150 to
051742c
Compare
|
I think this needs some discussion:
Regardless, I think we want to support the last 2 versions of Go, so even when Go 1.19 is superseded by Go 1.20, I believe we will still want our Of course, this is just my opinion. Need the rest of @containerd/committers to offer their opinions. Also, the name of the PR is confusing given the existence of Go 1.19 used everywhere in our CI and release process :) Maybe you mean "Remove Go 1.18 support" |
|
close by #8109 |
|
@fuweid that doesn’t really bump the version… |
|
@lucacome sorry for the mistake. :( Please feel free to file other pr to upgrade the version in go.mod. Sorry for any inconvenience! |
Changes:
1.19go.modGo 1.19 is required for #7803 (see here)