Skip to content

Minor fix when querying pod sandbox status#7812

Merged
estesp merged 1 commit intocontainerd:mainfrom
mxpv:cri
Dec 14, 2022
Merged

Minor fix when querying pod sandbox status#7812
estesp merged 1 commit intocontainerd:mainfrom
mxpv:cri

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Dec 14, 2022

Signed-off-by: Maksym Pavlenko [email protected]

Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv added area/cri Container Runtime Interface (CRI) easy-to-review Easy to review labels Dec 14, 2022
@mxpv mxpv added this to the 1.7 milestone Dec 14, 2022
@dcantah
Copy link
Copy Markdown
Member

dcantah commented Dec 14, 2022

Was the bug that they can be different IDs (the ID in the request and the one present in the cached Sandbox object)?

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Dec 14, 2022

Was the bug that they can be different IDs (the ID in the request and the one present in the cached Sandbox object)?

r.GetPodSandboxId() might be in a shortened form, so in-memory sandbox store resolves it to a full ID. That one should be used to query things from containerd's metadata store.

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Dec 14, 2022

Ahh, that makes sense

Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 9b39b0b into containerd:main Dec 14, 2022
@mxpv mxpv deleted the cri branch December 14, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) easy-to-review Easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants