Skip to content

fix sdNotify func when debug level#7798

Merged
fuweid merged 1 commit intocontainerd:mainfrom
calvin0327:fix-sdNotify
Dec 12, 2022
Merged

fix sdNotify func when debug level#7798
fuweid merged 1 commit intocontainerd:mainfrom
calvin0327:fix-sdNotify

Conversation

@calvin0327
Copy link
Copy Markdown
Contributor

@calvin0327 calvin0327 commented Dec 11, 2022

When I was debugging locally with flag --log-level=debug, I saw the following log message：

image

so, if the err is nil, we should not to print the message.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Dec 11, 2022

Hi @calvin0327. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Dec 11, 2022

would you use real name in the signoff ? Thanks

@calvin0327
Copy link
Copy Markdown
Contributor Author

calvin0327 commented Dec 12, 2022 •
edited
Loading

would you use real name in the signoff ? Thanks

that's sure. updated

@fuweid fuweid merged commit 5e51347 into containerd:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calvin0327 @k8s-ci-robot @fuweid @AkihiroSuda